commit dc8b3d0c3ca680933cffa0aafe04fed821ea52ca Author: Stephan Wiesand Date: Tue Jun 18 15:50:03 2013 +0200 make openafs 1.6.4 The wrong commit was tagged for the 1.6.3 release by accident. Update the version strings to 1.6.4, and adapt the release notes. Change-Id: I0c4f8e796a1017aebaaf6c219fd12e1547ad9319 Reviewed-on: http://gerrit.openafs.org/9983 Tested-by: BuildBot Reviewed-by: Derrick Brashear commit 74bd4b6e9fed92b188b91f7cf05438d7f1db53a7 Author: Stephan Wiesand Date: Sun Jun 16 21:15:53 2013 +0200 make openafs 1.6.3 update version strings for 1.6.3, finalize release notes Change-Id: I2f3e3dee0b1ea9e2fce522ad72e9018825b4103b Reviewed-on: http://gerrit.openafs.org/9976 Tested-by: BuildBot Reviewed-by: Stephan Wiesand Reviewed-by: Derrick Brashear commit f1702d57bcad2843f08341aaa46519a095d970ce Author: Stephan Wiesand Date: Thu May 30 16:52:26 2013 +0200 Update release notes for 1.6.3 As of pre3, we'll support Linux 3.10 clients (at least up to rc3). Change-Id: I81b783ad563e4a7735638bde2aa77d11ea1ec83c Reviewed-on: http://gerrit.openafs.org/9959 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Stephan Wiesand commit 6e92b66271df340917c4243404b5b85df7505e94 Author: Stephan Wiesand Date: Thu May 30 15:54:59 2013 +0200 make 1.6.3pre3 prerelease for OpenAFS 1.6.3 Change-Id: I92e3df57e9c8d55759c317cc8d7743c23c349399 Reviewed-on: http://gerrit.openafs.org/9958 Tested-by: BuildBot Reviewed-by: Derrick Brashear commit d5fcb35aea8a15bb8de760d2e27ef5734cfff16a Author: Marc Dionne Date: Mon May 6 20:20:07 2013 -0400 Linux 3.10: Replace create_proc_entry() with proc_create() Add an afs_proc_create() compat function that uses the appropriate kernel function based on a configure test. Reviewed-on: http://gerrit.openafs.org/9854 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear (cherry picked from commit 9b24013426e03a501fcaa6334ba5a9b48a8da3d1) Change-Id: I976ef345b1638434026e852e577e1f4474171e3d Reviewed-on: http://gerrit.openafs.org/9948 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 2bbd762c57003a9340d52edd517bc7540b1b2d8d Author: Marc Dionne Date: Wed May 15 15:19:22 2013 -0400 Linux 3.10: Include linux/aio.h directly This file needs bits from linux/aio.h, but gets them indirectly from the inclusion of aio.h by sched.h. That gets removed for Linux 3.10. Since this header is not of general interest elsewhere, just include it directly here. Reviewed-on: http://gerrit.openafs.org/9912 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Tested-by: BuildBot (cherry picked from commit fca4252621b80c5126e1ae3d84a54da5ebc677ba) Change-Id: I7da471ee033087592b9ec3f10331baf0135cc201 Reviewed-on: http://gerrit.openafs.org/9947 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Stephan Wiesand commit b9984671c567ec82e128f64a1f3612348f2b156c Author: Stephan Wiesand Date: Wed May 15 19:36:14 2013 +0200 make 1.6.3pre2 prerelease for OpenAFS 1.6.3 Change-Id: Ie6148239feae53bdaca9409c6b75714a25968c00 Reviewed-on: http://gerrit.openafs.org/9909 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 4d59d59dc04e25cc59da19a71a0400116d10e0fc Author: Stephan Wiesand Date: Wed May 15 19:46:56 2013 +0200 Update release notes for 1.6.3 We merged another change, helping Linux 3.6+ clients. Mention it. Change-Id: I71d2ee7f2b6fc591d767f37436d0e154809e0786 Reviewed-on: http://gerrit.openafs.org/9910 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit af2dda555adfa71bc6a84e04f72523273aca6c16 Author: Antoine Verheijen Date: Mon Apr 8 20:29:58 2013 -0600 OpenBSD 5.3: Replace use of copyinstr for setting mount point name. As a result of a realignment of kernel memory in OpenBSD 5.3, the copyinstr() routine no longer works for copying the mount point name into the internal mount table structure. It also fails silently, so it's not noticed until someone looks at the mount table and discovers that the mount point name for AFS is missing. This patch replaces the use of copyinstr() with strlcpy() for copying the mount point name in OpenBSD 5.3. Note that this is consistent with how other similar device support has addressed the same issue in OpenBSD 5.3. Reviewed-on: http://gerrit.openafs.org/9752 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit b39461fc67d4f258d31e0a13b5d8dcb3c5fae49f) Change-Id: I5e9a3d0871360e0e3b19cdb2b4a609baeed050f8 Reviewed-on: http://gerrit.openafs.org/9908 Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit a71cc5511c115c1b6cb4a6a2997a846bab6e19e2 Author: Anders Kaseorg Date: Tue May 7 00:27:33 2013 -0400 Linux: osi_TryEvictVCache: Don’t skip the first dentry if D_ALIAS_IS_HLIST An hlist doesn’t begin with a sentinel like a list does, so the old code would skip the first dentry or crash with a NULL dereference if there wasn’t one. Use the kernel’s list_for_each_entry or hlist_for_each_entry macros instead of trying to do it manually. Should fix a crash observed by Alex Chernyakhovsky on kernel 3.6 and newer. Signed-off-by: Anders Kaseorg Reviewed-on: http://gerrit.openafs.org/9857 Reviewed-by: Alex Chernyakhovsky Tested-by: Alex Chernyakhovsky Tested-by: BuildBot Reviewed-by: Marc Dionne Reviewed-by: Jeffrey Altman (cherry picked from commit ad6e31d5fea221bf5eefcd35a416667bc7c1f9be) Change-Id: Id8b31246067b5a718af91c8c206d5abd5210c558 Reviewed-on: http://gerrit.openafs.org/9898 Tested-by: BuildBot Reviewed-by: Marc Dionne Reviewed-by: Stephan Wiesand commit 3afe8cd715859ec4e758e6b43c82851893dc706e Author: Stephan Wiesand Date: Tue May 7 18:45:53 2013 +0200 make openafs 1.6.3pre1 prerelease for 1.6.3 Change-Id: I8eb600cdc0ed55d15e928a9f165f68d3ff924f82 Reviewed-on: http://gerrit.openafs.org/9858 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear Reviewed-by: Ken Dreyer Reviewed-by: Stephan Wiesand commit c0457a046d14c6df8253c9ab33f948da6d1893f7 Author: Stephan Wiesand Date: Tue May 7 20:46:47 2013 +0200 Preliminary release notes for 1.6.3 Change-Id: Ie4a6a984cfd9b819b0a3170acce7817998307157 Reviewed-on: http://gerrit.openafs.org/9859 Reviewed-by: Ken Dreyer Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit b8a7861ed01fb01ef90c491a5bf1fcda79d3ce36 Author: chas williams - CONTRACTOR Date: Mon Sep 5 09:26:32 2011 -0400 ppc64_linux26: build binaries as 64-bit by default lwp doesnt work since ucontext/setjmp are incomplete when running 32-bit binaries with the 64-bit kernel. Reviewed-on: http://gerrit.openafs.org/5365 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 39b788eeafe27d21ae6b4fd3cfeb59ce5dc70077) Change-Id: Ic4fd5c1a861db8e96dd58a79d7fb2ea73ab4f0d6 Reviewed-on: http://gerrit.openafs.org/9605 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Stephan Wiesand commit 9be556d2c1c15ffc1561a6f03d2381430ba1c21c Author: Andrew Deason Date: Thu Mar 28 13:03:40 2013 -0500 afsio: Pass KRB5_LDFLAGS along with KRB5_LIBS We need this in case e.g. the krb5 library we're using is in an alternate location, so we can pass -L. aklog already does this, so do it for afsio, too. This is a 1.6-only change. On master, this problem went away when the krb5 ldflags/cflags/etc were standardized in commit 6f9443e702745d1e371eb72ad7fcba5cac47f3db. Thanks to Måns Nilsson for reporting this. Change-Id: I79aeb1f4de123b7550b64c1890a2773a44ff8d1e Reviewed-on: http://gerrit.openafs.org/9692 Reviewed-by: Simon Wilkinson Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit c18835330e9bec04672baf78eb1ff7fce47c4263 Author: Ken Dreyer Date: Tue Apr 30 21:59:32 2013 -0600 doc: quote list items in POD Recent versions of Pod::Simple complain if we use integers or other special characters in an =item list. We have a couple bulleted lists that happen to have integers or other special characters as the list values. Quote the items with C<> so that Pod::Simple can correctly parse them again. Reviewed-on: http://gerrit.openafs.org/9838 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman (cherry picked from commit 32d823c52f212fb79816708418ad7d958eb32a01) Change-Id: Ie3e5c792d64f1d2e973e3a5f68b8466986cde0d7 Reviewed-on: http://gerrit.openafs.org/9842 Tested-by: BuildBot Reviewed-by: Jason Edgecombe Tested-by: Jason Edgecombe Reviewed-by: Stephan Wiesand Tested-by: Stephan Wiesand commit 753d3380f30f7277b88365fe1994072ae75a8be7 Author: Andrew Deason Date: Tue Apr 30 14:37:54 2013 -0500 afs: Do not invalidate all dcaches on startup Commit 20b0c65a289e2b55fb6922c8f60e873f1f4c6f97 changed afs_UFSGetDSlot to always treat a dslot entry as invalid if 'datavalid' was 0. This was to force the invalidation of the given dslot if we were reading in a dslot from the free or discard list, since the data in that dslot is not valid. However, 'datavalid' is also 0 when we read in dcache entries from disk on startup. So, this means that we invalidated all cache entries when the client started up, effectively making our persistent cache worthless. Fix this by only forcing this invalidation when we are reading from a free or discarded dcache, and not during the initial cache scan. That is, when 'indexvalid' is 1, and 'datavalid' is 0. The parameters for these Get*DSlot variants should maybe be changed to be a little more clear, but for now, this is a targeted fix for this specific issue. FIXES 131655 Reviewed-on: http://gerrit.openafs.org/9833 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Marc Dionne Reviewed-by: Derrick Brashear (cherry picked from commit 479c34614f33859131258e330e7a3f8494e0bc80) Change-Id: I72b7ad41658c51b81aa9844327372724a0f3151e Reviewed-on: http://gerrit.openafs.org/9837 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Marc Dionne Tested-by: Stephan Wiesand Reviewed-by: Stephan Wiesand commit be2cc944febb262ae0168bf5fe9411b6ef611469 Author: Andrew Deason Date: Fri Mar 29 13:40:41 2013 -0500 Make ihandle sync behavior runtime-configurable The actual behavior of FDH_SYNC has changed a bit over the years, and some people want one behavior, and some want another. Make it possible to make this choice at runtime with the new -sync option, instead of making this decision by running with different patches. Note that FDH_SYNC is not a macro anymore, nor is it an inline function. While it could be a macro, it would look a bit complex, and there are some oddities with trying to use vol_io_params inside the FDH_SYNC expansion (vol_io_params is not declared for LWP, for example). And having it be an inline function causes problems with some odd linking dependencies. For example, vlib.a contains volume.o, but does not contain a definition for DFlushVolume (dir/buffer.c), which is referenced in volume.o. 'vos' uses vlib.a, but does not bring in anything that defines DFlushVolume. Currently this appears to not cause a problem because 'vos' uses nothing from volume.o, so the dependencies of volume.o don't matter. Adding an inline FDH_SYNC for platforms that don't support 'static inline' would add a dependency to volume.o (via vol_io_params), which causes an error for the lack of a DFlushVolume. Those are possibly just some problems, and may not be all. So instead, make it so we don't have to deal with that and just have a normal function. While FDH_SYNC may be called in a performance-critical section, the overhead of a real function call is nowhere near the delay of an actual fsync(), so presumably any overhead doesn't matter. Reviewed-on: http://gerrit.openafs.org/9694 Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit eb5190eb4a7cd95166866a89e0a8f3a69bbc6e8f) Change-Id: I7a6c99d00eff3400423440db91a350053ed099ea Reviewed-on: http://gerrit.openafs.org/9695 Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Jeffrey Altman Reviewed-by: Stephan Wiesand commit d99de7f2e869c9dcf2873f0c62d7fbe54f7afe43 Author: Andrew Deason Date: Wed Apr 17 18:04:58 2013 -0500 LINUX: Sometimes let dentry_open handle refcounts When Linux changed dentry_open to use a 'path' argument, they also changed it so dentry_open handles incrementing the relevant ref counts. So now, sometimes we need to inc the dentry and vfsmount refcounts ourselves, and sometimes we need to leave them alone. To accommodate this, change afs_dentry_open to also handle refcounting itself, and 'get' the given dentry and vfsmount if necessary. Also note that currently, afs_linux_raw_open can call afs_dentry_open twice in the case of an error, but it does not dget(dp). This means that dp could be undercounted, since dentry_open on older kernels will dec the refcount on the given dentry in the case of an error. This change should also fix this so dp is not undercounted in that case. FIXES 131613 Reviewed-on: http://gerrit.openafs.org/9801 Reviewed-by: Derrick Brashear Reviewed-by: Marc Dionne Tested-by: BuildBot Reviewed-by: Andrew Deason (cherry picked from commit e31240732cbe449fedea5095037ac08d1d513fa9) Change-Id: I082063d324d99c3d02ed372a1c20462f13bb4a26 Reviewed-on: http://gerrit.openafs.org/9803 Tested-by: BuildBot Reviewed-by: Marc Dionne Reviewed-by: Derrick Brashear Reviewed-by: Simon Wilkinson Reviewed-by: Stephan Wiesand commit d572281d5db2896362e9addf8a8157c618e3a776 Author: Andrew Deason Date: Wed Apr 17 01:27:47 2013 -0500 LINUX: Avoid duplicate mntget in afs_dentry_open Our caller already got a ref to 'mnt'; getting another one here will overcount refs on 'mnt'. This can make it impossible to unmount the filesystem the cache resides on (even after the client is stopped), since it's ref count will be very high. FIXES 131613 Reviewed-on: http://gerrit.openafs.org/9790 Tested-by: BuildBot Reviewed-by: Stephan Wiesand Tested-by: Stephan Wiesand Reviewed-by: Marc Dionne Reviewed-by: Derrick Brashear (cherry picked from commit e019429d4548348c6ab8674305d985feee040476) Change-Id: If88e108bb3e67602cf9e6bbe7646f9862228b684 Reviewed-on: http://gerrit.openafs.org/9792 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Marc Dionne Reviewed-by: Stephan Wiesand Tested-by: Stephan Wiesand commit 323d961862033496d5d3d5838c02a21eafdb8352 Author: Antoine Verheijen Date: Tue Jan 22 19:24:25 2013 -0700 OpenBSD: Add config headers for new(er) OS versions. The OS-specific config header files have not kept up with the newer releases of OpenBSD. This patch corrects that by adding header files for OpenBSD versions from 4.9 to 5.3 (the newest version currently under development). Reviewed-on: http://gerrit.openafs.org/8927 Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 20a54b02521b40b07e4ec87df55a1e9a2549c881) Change-Id: I9ee66dbba300d5a68bc294a14dd9463441143371 Reviewed-on: http://gerrit.openafs.org/9661 Reviewed-by: Simon Wilkinson Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Reviewed-by: Derrick Brashear Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 1243f1c034af37079501c5d546a613c406bc32d5 Author: Andrew Deason Date: Tue Nov 20 15:00:15 2012 -0600 ubik: Do not count votes from error'd connections If the given connection has a connection-wide error on it, the vote we got from that site is probably not valid, and we could easily be interpreting an error code as a vote time. So instead, treat the host as if we got a network error from it. Reviewed-on: http://gerrit.openafs.org/8487 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 23092acce5d2d71a5ad6402119973c7c2c2f5e89) Change-Id: Id320b33bb6662d7867ae1f4a8d0a29808f16b59d Reviewed-on: http://gerrit.openafs.org/8947 Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Reviewed-by: Simon Wilkinson Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit a369628d2c0a2f91a894ea5781166a18329b896d Author: Andrew Deason Date: Tue Nov 20 14:18:47 2012 -0600 ubik: Try to detect VOTE_Beacon errors Currently the way ubik dbsites vote for each other is via the "return value" of the Beacon VOTE RPC. Since this is really an Rx abort, this can easily collide with actual errors on the wire, such as rxkad errors. Try to detect these by detecting vote times that are very different than the current timestamp (more than an hour in the future or past), and treat it like a network error. If we do not do this, a single site reporting an error can cause us to never reach quorum, since we calculate our sync site expiration based on the oldest 'yes' vote, which for most known Rx aborts will be far in the past. Reviewed-on: http://gerrit.openafs.org/8486 Reviewed-by: Jeffrey Altman Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 4d4668b1618a2bd5b94ed4620464787f42d11cab) Change-Id: Iaca12506a35e924631754b638f99cb12faa84479 Reviewed-on: http://gerrit.openafs.org/8946 Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Reviewed-by: Simon Wilkinson Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 538fdd3860927a90dfd4ade9d9daa2de8113e37b Author: Jeffrey Altman Date: Thu Mar 14 23:27:25 2013 -0400 vol: remove duplicate stmp declaration Patchset 38cf31463e3f3c675de727c1e793e117a90e6d20 added a definition of afs_ino_str_t stmp which should have replaced the b64_string_t stmp declaration that was already present. Thanks to Jason Madar for noticing. FIXES 131620 Reviewed-on: http://gerrit.openafs.org/9608 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit dd903ce729c24c9d1ed78b227a261b2549482461) Change-Id: Ia0a43f64183b47b6df30495673907d176d95799a Reviewed-on: http://gerrit.openafs.org/9771 Reviewed-by: Derrick Brashear Reviewed-by: Simon Wilkinson Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 44e97c45f3700ead06db25e1027ca0314647c932 Author: Andrew Deason Date: Wed Apr 3 16:39:07 2013 -0500 vos: Restore some VNOVOL error messages Many places in vos/vsprocs have code to delete a volume. Commit f4e73067cdef990262c69c38ac98761620a63f25 tried to refactor them by consolidating the common "delete" code into DoVolDelete. However, not all of the removed code had exactly the same behavior, and some of these variants were not handled by DoVolDelete. One such variation is that DoVolDelete always printed an error message if the target volume did not exist. But for some call sites this condition is not an error, and prior to the refactoring they did not print such an error message. Commit 1092cbe34fc8519826b3fa0565505b7bd81bc922 tried to correct this by suppressing the error message if the target volume does not exist. However, this means that all DoVolDelete calls do not print such an error, where some should and some should not print an error. This means that in some edge cases when we encounter an unexpected VNOVOL error, we now skip printing the specific error we got and instead go right to cleanup/recovery/exit. For a few other cases, we used to print an error and continue (because it is a non-fatal error or a warning), but now we print nothing when we encounter a VNOVOL error. Fix this by specifically printing an error for the VNOVOL error for DoVolDelete call sites that used to print such an error. Do this for all such sites except ones where we obviously print an error immediately afterwards anyway. This is just a quick targeted fix. A future more robust fix should involve altering DoVolDelete to handle all of the different behaviors expected by its various callers. Reviewed-on: http://gerrit.openafs.org/9704 Reviewed-by: Mark Vitale Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 0a063815cc27ed065bcc9e4a91fb3a7b280818bb) Change-Id: Ia333b2257b9fdc39f7bcc9ba8ed3c98254d2e76a Reviewed-on: http://gerrit.openafs.org/9770 Tested-by: BuildBot Reviewed-by: Mark Vitale Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand commit ddaef4378de7af439de1d574155506f659ca8c56 Author: Mark Vitale Date: Thu Mar 7 09:34:55 2013 -0500 vos: noise messages when attempting to delete non-existent volume With vos refactor commit f4e73067cdef990262c69c38ac98761620a63f25, some formerly conditional volume deletes are now unconditional. This regresses 'vos move' output with harmless "error" messages when AFSVolTransCreate() returns VNOVOL: "Failed to start transaction on " "Volume not attached, does not exist, or not online" Modify DoVolDelete() to return early (and silently) with VNOVOL in this case, allowing the caller to handle this appropriately. Reviewed-on: http://gerrit.openafs.org/9596 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit 1092cbe34fc8519826b3fa0565505b7bd81bc922) Change-Id: I77e701378a999c8ad9413bfefcace0ee06aecb07 Reviewed-on: http://gerrit.openafs.org/9597 Reviewed-by: Stephan Wiesand Tested-by: BuildBot Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear commit 1c811f9fddf336317099e7ec73e28131acf65be8 Author: Marc Dionne Date: Sat Dec 22 07:54:54 2012 -0500 Rework set_header_word macros Rework the set_header_word macros so that all compilers are happy: - the use of offsetof() is avoided, as it has an issue on IRIX when the result is not constant - the assignment within the macro is explicitely sequenced before the function call to avoid a gcc sequence-point warning Reviewed-on: http://gerrit.openafs.org/8816 Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear (cherry picked from commit 7f96084969d3082842a9575ee8ff7da8c52a0796) Change-Id: Iefdf7f6dbb60ffc569b67b3c89893fb43527eb02 Reviewed-on: http://gerrit.openafs.org/8818 Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand commit e8307ef10c5653ffa597b58384686141adba58f7 Author: Derrick Brashear Date: Tue Jul 17 15:34:07 2012 -0400 macos: get more packets if requested analogous to eead07418f13cd87a90770f03ea5118c546d8f1a for ukernel, this is for macos' upcall procedure Reviewed-on: http://gerrit.openafs.org/7788 Reviewed-by: Jeffrey Altman Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 33a761ebd11e33b5e111e67204218e8f67bef431) Change-Id: I1b59c802717393758370c376f95569467dc61049 Reviewed-on: http://gerrit.openafs.org/9747 Reviewed-by: Jeffrey Altman Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 0508bdf0be69e93895df2f2d4bd26a06faf21c7b Author: Andrew Deason Date: Tue Dec 18 18:49:49 2012 -0600 viced: Sanity check file link count during CoW A few ihandle bugs in the past have caused the CopyOnWrite code to open cached file handles for files which have been deleted. When we CoW, both of the files we're dealing with had better actually be on disk, so bail out and flag an error if either of them appear unlinked. FIXES 131530 Reviewed-on: http://gerrit.openafs.org/8839 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 752514bd1c8eaae487d25116dc59853552f77d12) Change-Id: I2aa70145b12e9babd1a1eb881bf7f48151c20f6c Reviewed-on: http://gerrit.openafs.org/9508 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 5e05f22798cce04ab1c76f979eeeb578f1e72f97 Author: Andrew Deason Date: Fri Dec 21 12:30:24 2012 -0600 ihandle: Add FDH_ISUNLINKED Add the FDH_ISUNLINKED functionality to ihandle. This lets the caller know if the file for the underlying file descriptor has been deleted out from under us. This is useful for sanity checks in some callers. Reviewed-on: http://gerrit.openafs.org/8838 Reviewed-by: Chas Williams - CONTRACTOR Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 9cf9a0e978ece2b0afb8ba5947455f307a424cab) Change-Id: If5cde825a2e7413c47409c69f15507d6df1934c3 Reviewed-on: http://gerrit.openafs.org/9507 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit e2f29a79a7c6e385bac8cace970a5d0053b17edb Author: Andrew Deason Date: Fri Dec 14 15:05:53 2012 -0600 volser: Check vnode length on dump Commit aadf69eabb1962496fa93745ab560a5b48cacd61 adds length checks on vnodes during fileserver read/write operations. Do the same thing when we dump volume data from the volserver, to ensure that we don't transmit incorrect data e.g. to other RO sites when releasing. FIXES 131530 Reviewed-on: http://gerrit.openafs.org/8836 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit eb938bd18d9806f3529b7a2cbccdce5340c0e39f) Change-Id: Ia49e7310f2e143d4eed965a5090e687be55864e4 Reviewed-on: http://gerrit.openafs.org/9505 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit c40eb13d019203aa73e3ba3b25d6a8dcc950ff05 Author: Andrew Deason Date: Fri Dec 28 16:49:20 2012 -0500 afs: Add a little more info on SLVC loop panic If we panic due to a perceived infinite loop, log a little more info about our loop iterations. Reviewed-on: http://gerrit.openafs.org/8850 Tested-by: BuildBot Reviewed-by: Marc Dionne Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear (cherry picked from commit 2f087dc434f62cfa7888434427eaac6803b563ab) Change-Id: Ie4a02a40fafa88f8b54b05b8a0926f258ae7cf7a Reviewed-on: http://gerrit.openafs.org/9509 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Stephan Wiesand commit 96389a9996eeb8b6e03b2ddadacefae1ceb1cb44 Author: Andrew Deason Date: Wed Nov 28 15:12:12 2012 -0600 afs: Apply VLRU safety check for Linux too This invariant should apply to all platforms, not just those with dynamic vcaches. Since this prevents an infinite loop if the list os corrupt or something, having this around everywhere seems useful. So, drop the check for afsd_dynamic_vcaches. Reviewed-on: http://gerrit.openafs.org/8555 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 696db8667d12b1c5639515840f69c9a46d2b866d) Change-Id: I81e4c7c7678a9f4a3e02952e243735d59b3af35c Reviewed-on: http://gerrit.openafs.org/9502 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit ef562f58195a75cb8c9e7437ced6f1f40387f8ec Author: Michael Meffie Date: Sat Mar 3 10:05:01 2012 -0500 viced: fix log message for MapName_r Do not log a code of zero if the name plus instance length exceeds the max pr name buffer. Reviewed-on: http://gerrit.openafs.org/6861 Reviewed-by: Derrick Brashear Reviewed-by: Alistair Ferguson Tested-by: Derrick Brashear (cherry picked from commit ef6ae1e7eda56e1d6ff7b9ade25b290c855e5780) Change-Id: If644670ed522eaba575e7246084f106231649991 Reviewed-on: http://gerrit.openafs.org/9474 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 1e8f1c7727d77e469ed83d51f314e6e66e4ea518 Author: Andrew Deason Date: Thu Jul 8 11:25:19 2010 -0500 viced: Ignore client loopback alternate addresses When we receive interface information from a client to determine its alternate IP addresses, ignore any addresses that look like loopback. Reviewed-on: http://gerrit.openafs.org/2368 Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear Reviewed-by: Alistair Ferguson Tested-by: Jeffrey Altman (cherry picked from commit 2a6ddae62e4fac5eecdf4634746e7294405393d6) Change-Id: Idcdaabd3aad62f0e84efbaf1d8523338bc683924 Reviewed-on: http://gerrit.openafs.org/9466 Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit d4d6ece9e1791dcc3717407df71878bc61a3d5f9 Author: Andrew Deason Date: Tue Feb 21 18:03:24 2012 -0600 salvager: Remove PrintVolumeSummary Nothing uses this function; remove it. Reviewed-on: http://gerrit.openafs.org/6785 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit d426e613b9a4802c3b404903f7122f6fd0046aba) Change-Id: Ibca098550a073013228c4907fbbeab7f3c0333ae Reviewed-on: http://gerrit.openafs.org/9460 Reviewed-by: Stephan Wiesand Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: BuildBot commit a0f0be1295440c36a24de4c892ef298f571b92c6 Author: Andrew Deason Date: Tue Nov 29 12:07:49 2011 -0600 udebug: Fix endianness when fudging lastYesHost hostAddr is in NBO, lastYesHost is in HBO. Reviewed-on: http://gerrit.openafs.org/6136 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 073edd3fbdf442249920acea8f3ee90b6346bf23) Change-Id: Iea4f7799c8f5500010448d6104cc9f701663d826 Reviewed-on: http://gerrit.openafs.org/9437 Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 2f0a1ed60eabc8863439f30c46618ad797ac73b9 Author: Simon Wilkinson Date: Fri Aug 20 13:17:53 2010 +0100 Configure: Tidy up AC_CHECK_FUNCS Move all of our AC_CHECK_FUNCS calls into a single, ordered, list so that it's easier to see what's being checked for and what's not. Reviewed-on: http://gerrit.openafs.org/2598 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit 3fc5863f062c14c346bcc50c82b8d15971750e55) Change-Id: I167b42d84c9ddbb8b35aee6b4ced3c7a809e72dc Reviewed-on: http://gerrit.openafs.org/9423 Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit e46f2cdb540d6a9648aaebe8158f44b6e18df1d8 Author: Simon Wilkinson Date: Mon Jan 3 10:40:56 2011 +0000 autoconf: Tidy up header includes Tidy up our list of header includes so it's easier to see what we're testing for. The list is now one-per-line, in alphabetically sorted order. Note that this won't affect our use of the default include set, as autoconf will already have tested for all of those before it starts this CHECK_HEADERS run. Reviewed-on: http://gerrit.openafs.org/3612 Tested-by: BuildBot Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit c8fc94fb86255a2c5cbd1613b33e32ec3a4d3b21) Change-Id: I0b507dcd9578d1c041731f7f7923f27e33fc89df Reviewed-on: http://gerrit.openafs.org/9411 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 65ae1315891e4c4802b82bdeceea40d20865a648 Author: Simon Wilkinson Date: Wed Apr 3 07:09:03 2013 -0400 fix garbage counters in supergroup prdb_check This is a backport of one hunk of commit 9efc255ab8de7ad90c7d599fea7bd1956bfd48c2, where a calloc fixes an incorrectly sized memset. The original memset clears the size of the pointer, not the sizeof the structure. Change-Id: I40250e0346345fe9b4b43d14e76ea5fb23c8c04b Reviewed-on: http://gerrit.openafs.org/9701 Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 703849934244f67bfbae1bb83169a5f32a4eab9d Author: Andrew Deason Date: Tue Mar 26 13:27:33 2013 -0500 aklog: Only try to use krb5-weak.conf if it exists The logic we use for using krb5-weak.conf to allow 'weak crypto' requires us to know where the default krb5.conf is. The default krb5.conf local can vary significantly depending on the platform, and we don't have a good way of figuring out what it is, so we guess. We may guess wrong. To limit the cases where we guess wrong, only try to do this workaround if the krb5-weak.conf file actually exists. Reviewed-on: http://gerrit.openafs.org/9667 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: BuildBot (cherry picked from commit 95240a5a5030a1053ce9966b54037eda2d37140b) Change-Id: I02313b2cc37da05adc0529e685abf6a8546bb3de Reviewed-on: http://gerrit.openafs.org/9687 Tested-by: BuildBot Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand commit 3789e98f8850188c9b5e169e98ba54bf388ae52c Author: Andrew Deason Date: Tue Mar 26 13:14:30 2013 -0500 aklog: Search for /etc/krb5/krb5.conf aklog tweaks the KRB5_CONFIG environment var when performing one of our 'weak crypto' workarounds. We assume that the default krb5.conf is /etc/krb5.conf, but for Solaris 11 libkrb5, krb5.conf is in /etc/krb5/krb5.conf. Although this file could be anywhere, try /etc/krb5/krb5.conf too, so we at least work on stock Solaris. Reviewed-on: http://gerrit.openafs.org/9666 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit cd1ffc1073d6f9a191e07cb72e8d0b4ec8cd6347) Change-Id: I8eeb406107592bac6da415d25b688d936a385a87 Reviewed-on: http://gerrit.openafs.org/9686 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand commit 710b40e388dcff8d3b64476a02fdc13b60e31ced Author: Andrew Deason Date: Wed Dec 21 22:00:12 2011 -0500 afsd: Parse cacheinfo during argument parsing Currently we parse cacheinfo in afsd_run, when the client is initialized and started. Parsing cacheinfo can change afsd_cacheMountDir, however, which may be of interest to afsd.o users; in particular, libuafs exposes this via uafs_MountDir(). This means that if a mount dir is not explicitly specified in the libcmd arguments to afsd, a libuafs-using program will see the mountpoint as the empty string if it is queried after afsd_parse but before afsd_run. For afsd.fuse, this causes the cryptic error message: fuse: bad mount point `': No such file or directory since the mountpoint is the empty string if it is not specified explicitly on the command line. To fix this, move cacheinfo parsing to effectively near the end of afsd_parse, so the mountpoint is calculated in afsd_parse(). Reviewed-on: http://gerrit.openafs.org/6400 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit af218dee6c517f4636a18c681bff6f1212a7d9c0) Change-Id: Ibd087f52c9a6f1d98614f4fdbbc5b92ea0806506 Reviewed-on: http://gerrit.openafs.org/9453 Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand commit e64921531a0f100c269c659d6500a8b358e23f87 Author: Derrick Brashear Date: Mon Dec 20 16:36:42 2010 -0500 LWP: don't copy pid to a null pointer In LWP_CreateProcess we take a pid. if it's null, don't crash. Reviewed-on: http://gerrit.openafs.org/3556 Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 5d218831f3186d0d1dc7d3b00dd4a3b6a4a8757c) Change-Id: I96c0e2a8858fa929f0de22a774050aa63a200101 Reviewed-on: http://gerrit.openafs.org/9414 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Stephan Wiesand commit 7c2cc74e4dd0ab0dbe674bb55104a7ce148d858a Author: Marc Dionne Date: Thu Jan 24 21:38:28 2013 -0500 Linux: crset should use passed credentials When copying credentials in crset, take the passed credentials as the source instead of the current process credentials. This doesn't cause any problems currently since crset always gets called with the current credentials. Reviewed-on: http://gerrit.openafs.org/8980 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 3b733db8bf2bc3a1366554ae97814cc722437149) Change-Id: I4d0000a139d16fafe480f7ebccc6759da7dea6bb Reviewed-on: http://gerrit.openafs.org/9333 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand commit 01ee0551ba5f3d874a9d012b7b362813bb4212f1 Author: Simon Wilkinson Date: Wed Feb 27 10:34:59 2013 +0000 ubik: Avoid unlinking garbage If SDISK_SendFail fails before the pathname to the temporary file has been constructed, then the failure handler will unlink stack garbage, with variable results. Initialise the string, and check to see if it has contents before calling unlink Reviewed-on: http://gerrit.openafs.org/9299 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 44e806431bec3149a78127f5d1003e84e3a0b072) Change-Id: I366de3ce15a5e1ea855eb45110ff7acf1748c377 Reviewed-on: http://gerrit.openafs.org/9538 Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Reviewed-by: Derrick Brashear Reviewed-by: Michael Meffie Tested-by: BuildBot commit 67f5f38ec3145d6f53433975dc26e64499c05992 Author: Marc Dionne Date: Sat Jan 29 12:48:02 2011 -0500 ubik: cleanup DB lock usage in SDISK_SendFile Some failure paths can return from SDISK_SendFile with the database lock still held. Other failure paths will cause setlabel to be called without holding the lock. Rework the failure paths so we always release the DB lock before returning, and always hold it when calling setlabel. Reviewed-on: http://gerrit.openafs.org/4151 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit ad63745f357e377c613881fa3470b85d4d36fe36) Change-Id: I99cb359f108f604be75f19250fb697eb95b81947 Reviewed-on: http://gerrit.openafs.org/9418 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 42233dd65b7bf5c6cc31b10a0de728bc0c3495b0 Author: Rainer Toebbicke Date: Wed Sep 19 12:13:15 2012 -0400 butc: clean xbsa shutdown on control C when we catch a control-c, do a clean shutdown Reviewed-on: http://gerrit.openafs.org/8141 Reviewed-by: Chas Williams - CONTRACTOR Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit aea3c71e59ec30e84ca4e7383fd3b566ce94bbb6) Change-Id: I89665c29a522909e126214abaec008a18acb59d7 Reviewed-on: http://gerrit.openafs.org/9495 Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Derrick Brashear Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit d5daffef48b133d6a663d3072c75b201a3e7508d Author: Andrew Deason Date: Fri Dec 21 11:11:00 2012 +0000 ihandle: Indent ifdef maze According to the mesoamerican long count calendar, ifdef ladders will destroy the world in 2012. Reviewed-on: http://gerrit.openafs.org/8837 Reviewed-by: Chas Williams - CONTRACTOR Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit a04071e7940b26dc2a29ac3f0952b10321e7b786) Change-Id: I1db449283c709cba48cc887757c9109cfc4bd253 Reviewed-on: http://gerrit.openafs.org/9506 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 3336b6b5ef04773ce0cbe7c91acb48373581483e Author: Andrew Deason Date: Fri May 18 17:55:09 2012 -0400 afs: Do not avoid DNLC if fakestat is set Currently in afs_lookup we avoid putting an entry in the DNLC if 'force_eval' is unset, in order to avoid populating the DNLC with mountpoint symlinks (we want the target of the mountpoint to be in there instead, the root dir). However, if -fakestat or -fakestat-all are enabled, 'force_eval' is always false, since we only set it to true under certain circumstances when evaluating mountpoints. To fix this, populate the dnlc for non-mountpoints, even if force_eval is unset. Reviewed-on: http://gerrit.openafs.org/7431 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 35d5be2adf2456e26aa6b10935352dc19eb6b3f2) Change-Id: I32f859c4478432de65025f35ae0c484ff7fa1bf0 Reviewed-on: http://gerrit.openafs.org/9494 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Stephan Wiesand commit 099dca0adc65a54af3a37409c4b512600950dc13 Author: Andrew Deason Date: Mon Jun 18 17:01:24 2012 -0500 cacheout: Perform authenticated RXAFS_FlushCPS Fileservers may now require RXAFS_FlushCPS calls to be made with administrator tokens. So, try to make the call with admin tokens, and provide the usual -noauth and -localauth options. Reviewed-on: http://gerrit.openafs.org/7573 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit cb64dea75a114f6ebcba174be4e71c7fb5f85658) Change-Id: I0d8e38d3cc1b0e55f63cfa0e50fd9cd4cebc8c30 Reviewed-on: http://gerrit.openafs.org/9486 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit fcab44631cb5f3bac63eedfc25703aedff336c70 Author: Andrew Deason Date: Fri Dec 28 13:16:49 2012 -0500 viced: initInterfaceAddr_r regardless of ICBS code Currently we only call initInterfaceAddr_r for a host if a call to RXAFS_InitCallBackState3 succeeds. However, this leaves the host without a host->interface structure, which indicates that the host does not support UUIDs, and is represented by just a single host,port pair. But this is not correct; the host probably does have the relevant UUID associated with it, but it is just not responding. So, with the current code, we create a uuid-less host structure for a host that probably has a uuid; that host structure will probably never be used, and will just get deleted later. So instead, always call initInterfaceAdd_r. Do it before the ICBS call, so the host will be findable via UUID as early as possible. If the ICBS call fails, the host will be marked as 'down' later on. Reviewed-on: http://gerrit.openafs.org/8847 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit f2f7ba50ed61a6187814d633327a8cacda0f656f) Change-Id: I4847ec0350346d44883b5c5912867555292cf3db Reviewed-on: http://gerrit.openafs.org/9380 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Michael Meffie Reviewed-by: Stephan Wiesand commit 71bd2680b536ef0f5ed4dc9a08fbc475ed8dfe2d Author: Andrew Deason Date: Wed Aug 29 14:14:39 2012 -0500 LINUX: Detect non-vectorized aio functions In kernels before 027445c3, the functions generic_file_aio_read and generic_file_aio_write, as well as the fs operations aio_read and aio_write, do not deal with iovecs but rather just use a single buffer. Detect this, so our aio_read and aio_write implementations have the correct signatures. This removes several warnings on such kernels. Reviewed-on: http://gerrit.openafs.org/8020 Reviewed-by: Marc Dionne Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit e5ba359f64b5d8d874a31a50694398c17f27cfa1) Change-Id: I8d8ee81c2bcff2dc85c2ff3e70452a0af5639921 Reviewed-on: http://gerrit.openafs.org/9493 Reviewed-by: Andrew Deason Reviewed-by: Marc Dionne Reviewed-by: Derrick Brashear Reviewed-by: Michael Meffie Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 1d38a73cb31e44fdbd71f8d90635514936ec1b28 Author: Marc Dionne Date: Fri Apr 22 15:23:27 2011 -0400 Linux: cleanup aio support Code that called directly into the aio operations (ex: readv/writev) would bypass the AFS specific operations found in afs_linux_read and afs_linux_write. Rework the handlers: - For newer kernels with aio, let the kernel use its default read and write operations, and define the aio_read and aio_write operations, with the AFS specific bits, calling into generic_file_aio_read/write. The kernels default read/write operations are just wrappers around the aio versions. - For older kernels, leave things as is, pointing read and write to afs_linux_read/write Reviewed-on: http://gerrit.openafs.org/4563 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit a8c46e5010c0b4e41ad66458b8723e32f99b427d) Change-Id: I3c20064cc911aabfce576178c22fcdc1a99b8125 Reviewed-on: http://gerrit.openafs.org/9492 Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 70a77f25e449a1772fb3a17ec5bc1b3ecda13cd1 Author: Andrew Deason Date: Thu May 31 16:08:00 2012 -0500 vol-salvage: Indent some ifdefs Reviewed-on: http://gerrit.openafs.org/7513 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 80359f562a459ef1dba2cdf53ee486578b50752d) Change-Id: I36fdd58895928fc82f9542e3c0d2ec1db7551e42 Reviewed-on: http://gerrit.openafs.org/9479 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 33c642ae948fced53b457f1394fa97be4c1469f2 Author: Thorsten Alteholz Date: Sun Feb 3 11:58:25 2013 +0100 Beautify ubik_print() After lots of intermediate steps a call to ubik_print(), ubik_vprint() and ubik_dprint*() ends in vFSLog() which adds a timestamp to the output. So any call to ubik_print(), that does not contain a \n at the end, makes a mess of the logfile. The least invasive change will simply add this newline at the end of any ubik_print() call. This also prevents long lines in the log, which might appear on multi-homed hosts with lots of interfaces. FIXES 1446 Reviewed-on: http://gerrit.openafs.org/9059 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Andrew Deason Reviewed-by: Michael Meffie Reviewed-by: Derrick Brashear (cherry picked from commit dc32caae7768c486e610c4e56c6a78e9c918d975) Change-Id: I05892d6d9c47517208e21a3ab00bad2f30d58ba9 Reviewed-on: http://gerrit.openafs.org/9522 Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 0f1a9764b04278994c43afb4482dfafe233eff3c Author: Michael Meffie Date: Mon Dec 13 14:53:50 2010 -0500 xstat: print collection values in debug mode Print the values of the integers returned in the collection data when the -debug option is given to xstat_fs_test and xstat_cm_test test programs. This allows us to at least see what the unformatted values are when there is a mismatch in timeval sizes between the host and client (aka the 32/64 bit xstat bug). This change could break scripts which call the xstat test programs with the debug option. New debug output are prepended with 'debug:' to be easily ignored. Reviewed-on: http://gerrit.openafs.org/2878 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 13aeb1dcaee5ad4e95477464860963788c5d1469) Change-Id: Ief2f9346fad92e86aa2a214f1a462a10560c6e64 Reviewed-on: http://gerrit.openafs.org/9567 Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit ebca99d0b193cd3a720e26fa59b629b70f3dc929 Author: Simon Wilkinson Date: Wed Jul 13 13:53:08 2011 +0100 libafs: Fix statistics for PrefetchFromTape pioctl The PrefetchFromTape pioctl was overloading SetAcl's statistics. Give it a slot of its own. 1.6-only: Also give a slot for the master-only PSetTokens2, so xstat data will be more consistent across versions. Reviewed-on: http://gerrit.openafs.org/4989 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 4e9a49c58aa1a6c910b01fe995739d0852c75dd4) Change-Id: I718585a6ff6fcb39469bd6a007e6ebd2b59ef4fa Reviewed-on: http://gerrit.openafs.org/9468 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 0671e93abcf927d48f935283682e6761a933d558 Author: Marc Dionne Date: Tue Mar 5 20:54:50 2013 -0500 Linux 3.9: hlist iterator change hlist iterators have been reworked to not require a temporary node parameter. Reviewed-on: http://gerrit.openafs.org/9403 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit 9cfd7f768ca350d3b750e89e7ddb186bdad6f726) Change-Id: I47df8894467f4bb1c60cf239ec0ce0a4d6ca29aa Reviewed-on: http://gerrit.openafs.org/9639 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Michael Meffie Reviewed-by: Stephan Wiesand commit ef07580783ad7a7fa70bb41c27225d429865cdaa Author: Karl Ramm Date: Sun Dec 4 13:56:29 2011 -0500 Print "waiting for job termination" at most once. This message is useless, annoying, and is the UI equivalent of littering... but it does explain why your backup command is just sitting there. Reviewed-on: http://gerrit.openafs.org/6223 Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 6d6d52e18f3bd537331de6021a0fcc2e96fc48db) Change-Id: Ide51c7ef7c40426f34a5f1cb6c23395b0d93886a Reviewed-on: http://gerrit.openafs.org/9438 Reviewed-by: Derrick Brashear Tested-by: Andrew Deason Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 64d4d13c4491a6f27f2cd63dc85a629d44a4b71a Author: Andrew Deason Date: Tue Apr 3 18:13:17 2012 -0500 xstat_cm_test: Print all call info stats For CM xstat collecton 0 (function call statistics), there are many more stats given to us on the wire than we currently print. Change this so we print out everything in the afs_CMCallStats struct. Reviewed-on: http://gerrit.openafs.org/7047 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman (cherry picked from commit 1a458e8e72455e480ccf4c0e3fd926dd9af9beea) Change-Id: Ib263a26829bc538009f605ebb502895628e66fc2 Reviewed-on: http://gerrit.openafs.org/9469 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 3b26eb76a37fb858672d2bb59589086d230d7959 Author: Andrew Deason Date: Fri Dec 28 12:58:33 2012 -0500 viced: Avoid dangling uuid hash table entry Currently we add a given host to the uuid hash table, then call RXAFS_InitCallBackState3, and then only initialize the host->interface structure if the ICBS3 call succeeded. If the ICBS3 call fails, we have added a host to the uuid hash table, but the host structure does not contain that uuid. If the host is then deleted, we will not remove the host from the uuid hash table (since host->interface is NULL), and so the uuid hash table entry will still point to the freed host. If that host is then later looked up via that uuid, we can reference a freed host, which can cause all kinds of undefined behavior. So instead, add the host to the uuid hash table at the same time that we initialize the host->interface structure, inside initInterfaceAddr_r. FIXES 131277 Reviewed-on: http://gerrit.openafs.org/8846 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 7b642173c7cd7b6b7130214c1a940501736abbf0) Change-Id: I838b55244a9745dd07b7d633cb3091414162b0d5 Reviewed-on: http://gerrit.openafs.org/8868 Tested-by: Andrew Deason Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 7c964a259f62eca8044016477ebb8b11d84108b3 Author: Andrew Deason Date: Fri May 4 17:23:42 2012 -0500 Call rx_SetNoJumbo earlier For ubik server processes, rx_SetNoJumbo needs to be called before ubik initialization for it to effect the communication between dbservers; otherwise, full database transfers may result in Rx jumbograms on the wire regardless of the jumbo/nojumbo setting. Move the call to rx_SetNoJumbo to before ubik initialization to avoid this. Also move the call to rx_SetNoJumbo to immediately after rx_Init* for all server processes, for consistency. Move similar calls to rx_SetMaxMTU for the same reason. Reviewed-on: http://gerrit.openafs.org/7350 Tested-by: BuildBot Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear (cherry picked from commit 0debf2d2274db1ea862bfdc2ef767372f1fa77e3) Change-Id: Iacb1afa853281e856bbb70f39c6ac9a81f210d0d Reviewed-on: http://gerrit.openafs.org/9121 Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Reviewed-by: Simon Wilkinson Tested-by: BuildBot commit 88c6a183de3e99ce386e8ee4f47b449e7c53c2e9 Author: Derrick Brashear Date: Thu Mar 7 06:53:16 2013 -0500 afscp: null-terminate root.cell dir if needed in dynroot mode instead of doing a check for something which will never be true, and then terminating, just terminate if it's not already null-terminated. Reviewed-on: http://gerrit.openafs.org/9439 Tested-by: BuildBot Reviewed-by: Chaskiel Grundman Reviewed-by: Derrick Brashear (cherry picked from commit ceac74a6baad79155adaa692639b1d9f403525b6) Change-Id: I14d3de25bca5b1ba1878048aac1973518f8c2359 Reviewed-on: http://gerrit.openafs.org/9583 Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 0b211ebe718977fe96ea1a62fbcdd8211396fddd Author: Marc Dionne Date: Mon Feb 11 18:49:21 2013 -0500 Linux: Add missing semi-colon Add a missing semi-colon in the error case when missing symbols are detected. The effect is strictly cosmetic - a few additional error messages would follow the "undefined symbols" error. Reviewed-on: http://gerrit.openafs.org/9095 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 50879d5727c183982a40bd242d6039ed470d835d) Change-Id: If2c1be51969131794cb2ea30f96490fce95b0103 Reviewed-on: http://gerrit.openafs.org/9365 Tested-by: BuildBot Reviewed-by: Paul Smeddle Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit cff3b5ddd1b92d769138ed97addb54602de3f540 Author: Marc Dionne Date: Sun Jan 27 20:52:39 2013 -0500 Linux: Detect undefined symbols in kernel modules Undefined symbols in the kernel modules are not currently detected at build time. As a result, buildbot may indicate success while the resulting kernel modules are unusable. In the kernel build process, modpost warns about missing symbols but does not return an error in the case of external modules. Detect these warnings and cause the libafs build to fail. Reviewed-on: http://gerrit.openafs.org/8981 Tested-by: BuildBot Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear (cherry picked from commit dbdee60a83d72d38a04a0eeb2a5324cf497e57e3) Change-Id: I1986dfd3c195be13b4014014b42eb745f9daf1f8 Reviewed-on: http://gerrit.openafs.org/9364 Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit d16fac9dfb55cc70bc9f868ee58db9ba143108e9 Author: Andrew Deason Date: Sun Feb 17 19:34:06 2013 -0600 rx: Assert call error for RXS_PreparePacket error If we've received an error from the underlying security class, we must not try to send the given packet, or we risk security issues. We currently achieve this by setting an error on the connection. It is slightly indirect in how this yields an error on this specific call, and so it may not be immediately clear, but doing so is critical. If somehow the call does not have an error by the end of this, we cannot proceed as this is an error condition we do not handle. So, assert. Reviewed-on: http://gerrit.openafs.org/9122 Tested-by: BuildBot Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear (cherry picked from commit 85f2a66ceafd7a13f51d0352c62b5d69f4620edb) Change-Id: Iae523e6f18dd73749a6be5c3d10e132e5c14a70c Reviewed-on: http://gerrit.openafs.org/9280 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Simon Wilkinson Reviewed-by: Michael Meffie Reviewed-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand commit 997a9980e33ae92abdaa81d07d0857d41dd6e9ae Author: Andrew Deason Date: Mon Jan 14 12:45:04 2013 -0600 rx: Honor RXS_PreparePacket errors rxi_PrepareSendPacket calls RXS_PreparePacket to allow the security class to modify the given packet appropriately (to be undone by CheckPacket on the other endpoint). However, currently rxi_PrepareSendPacket ignores all errors generated by RXS_PreparePacket, and processing continues as if there was no error. For rxkad, an error often results in the given packet being untouched. This means that the security checksum is not calculated, and thus not populated in the packet, and for encrypted connections means that the packet contents are not encrypted. This occurs for any error generated by the security class PreparePacket routine. For rxkad, the most common error is probably RXKADEXPIRED, though some other internal errors are possible as well. This behavior has a few effects for rxkad: 1. When any error is generated by PreparePacket, the other endpoint generally bails out with the error RXKADSEALEDINCON, since the security checksum of the packet is 0, which does not match what the checksum should be. This results in error messages like 'rxk: sealed data inconsistent'. This can be very confusing if the actual error is, say, just that the given credentials have expired. 2. For connections requiring encryption (rxkad_crypt), an error from PreparePacket means that the packet payload is sent in the clear. This can happen for about a window size's worth of packets. 3. If a client ignores errors/inconsistencies with the checksum and encryption, etc, they can keep reading data for the call forever, even after their credentials have expired. To fix this, make an error from RXS_PreparePacket cause a connection error for the given connection, and immediately send a connection abort. No further error checking should be necessary for the callers of rxi_PrepareSendPacket, since they already check for call/conn errors before sending any actual packets. Reviewed-on: http://gerrit.openafs.org/8909 Tested-by: BuildBot Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear (cherry picked from commit 03d3dacae16847352af754ac13c854ca0df0c08c) Change-Id: I5d0f421d22ca2e4d723df2d698088b6bbdc85f7b Reviewed-on: http://gerrit.openafs.org/9279 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Jeffrey Altman Reviewed-by: Stephan Wiesand commit b230e176d8e66090afb9225bf4d68c26006b5f5f Author: Dan van der Ster Date: Fri Dec 14 11:08:44 2012 +0100 rxperf: print achieved transfer rate Prints the client transfer rate in appropriate units (kbit/s, Mbit/s, or Gbit/s). Reviewed-on: http://gerrit.openafs.org/8758 Reviewed-by: Jeffrey Altman Tested-by: BuildBot Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear (cherry picked from commit 07d83cd473146a0db9c2ed521b6fa6ba607b0d40) Change-Id: Ia17b315e79313407e5479cd3710ac454d56ee7dd Reviewed-on: http://gerrit.openafs.org/9682 Tested-by: BuildBot Reviewed-by: Dan van der Ster Reviewed-by: Simon Wilkinson Reviewed-by: Jeffrey Altman Reviewed-by: Stephan Wiesand commit 2e8317d2018e89418abbe541e3ac9c5e5bb524c8 Author: Andrew Deason Date: Wed Dec 14 14:16:16 2011 -0600 viced: Yell when we GetSomeSpace_r A GetSomeSpace_r call indicates we don't have enough callbacks configured. For many people, this can happen without the administrator realizing anything is wrong, since we never give any indication that something is amiss, unless the administrator checks the xstat statistics. Since this can indicate a serious performance problem, yell in the log when this happens. Only do it once, so we don't spam the log. Reviewed-on: http://gerrit.openafs.org/6334 Reviewed-by: Michael Meffie Tested-by: BuildBot Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear (cherry picked from commit da3f8d86dd216a90bc400367b7b95e9a427f99e8) Change-Id: I63ec14c6f635c57249023e0fc34b15838cee2eb3 Reviewed-on: http://gerrit.openafs.org/9386 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 30ec61f2ee8c3c0651580e596489963ae27bd9a3 Author: Ken Dreyer Date: Mon Sep 10 11:20:26 2012 -0600 add a simple backport policy to README.GIT This will clarify where patches should go, and who can do backports. Reviewed-on: http://gerrit.openafs.org/8075 Reviewed-by: Andrew Deason Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman (cherry picked from commit 8662592caedbcf8e065312fe142731faabe1eb77) Change-Id: I1d2c452dd17c8ae63eebfd8d800659c9de0fc327 Reviewed-on: http://gerrit.openafs.org/9684 Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 0d76f5b07fd975bfb3a1fd0d1167f2c8dc061839 Author: Stephan Wiesand Date: Thu Mar 14 10:35:30 2013 +0100 Update NEWS for 1.6.2.1 Reviewed-on: http://gerrit.openafs.org/9602 Tested-by: BuildBot Reviewed-by: Ken Dreyer Reviewed-by: Jeffrey Altman Reviewed-by: Paul Smeddle Reviewed-by: Derrick Brashear (cherry picked from commit 5123deebdcbf634151b236bf7ff7ac7ca099b11e) Change-Id: I2d357e3fb385fcaa0e3da056e41ef8704007da6b Reviewed-on: http://gerrit.openafs.org/9664 Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 4f1018433734f03131f7f9a231892021de162f78 Author: Stephan Wiesand Date: Thu Mar 14 10:16:30 2013 +0100 Make NEWS match the 1.6.2 Release Notes Reviewed-on: http://gerrit.openafs.org/9601 Tested-by: BuildBot Reviewed-by: Ken Dreyer Reviewed-by: Stephan Wiesand Reviewed-by: Derrick Brashear (cherry picked from commit b74728590ce14f9b6c3235f0b51f8865caa9427d) Change-Id: I61acc90efd22e9577aa0447b93b3f81c6339da27 Reviewed-on: http://gerrit.openafs.org/9663 Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 8fb50638f5f71cac2e3e1e4956c55cd8d1de5863 Author: Simon Wilkinson Date: Thu Feb 28 17:05:29 2013 +0000 Unix CM: Update AFS_STATS_NUM_FS_RPC_OPS There are actually 30 elements in the AFS_STATS_FS array. When the ResidencyRpcs counter was added, the total number of operations wasn't updated. Fix this so that it is correct, although this still remains rather fragile. Reviewed-on: http://gerrit.openafs.org/9313 Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 2c8e4f839fc253abb8051bbf89d36e94a2200590) Change-Id: Id6094e6e5007984cb080281f6a085eba958d6367 Reviewed-on: http://gerrit.openafs.org/9540 Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Reviewed-by: Derrick Brashear Tested-by: BuildBot commit ae7ea148390fb2b41bfa7437e97ea55a099abb5f Author: Simon Wilkinson Date: Fri Feb 22 16:54:17 2013 +0000 Unix CM: Fix byte accounting for storebehind In the current version of CacheStoreDCaches, the stored variable is maintained within the for loop that iterates over the chunk list. This means that it is reset to 0 each time we handle a new chunk. However, this means that our progress is no longer accurately tracked, as (bytes - stored) no longer gives the number of bytes which remain to be transfered. In fact, as stored is zeroed with each loop iteration, (bytes - stored) == bytes. This means that store behind is no longer activated according to the users settings. Prior to commit 334114ac58b0039ae90d7e29fa2f019fe068bd79, the stored variable was maintained within the outer, function, scope. Just move it back there to restore the previous behaviour. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9237 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 5acb1a0f323a6692cca66ee3aa4c7e5f1a0f24f2) Change-Id: I22c60b07ba9518d5714c65b1952a35214f690433 Reviewed-on: http://gerrit.openafs.org/9530 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit e7be9bf929560a1f033b2513915781920884954d Author: Andrew Deason Date: Mon Nov 5 23:47:06 2012 -0600 afs_open: Deal with afs_GetDCache returning NULL afs_open was assuming afs_GetDCache always returned non-NULL. Make it deal with a NULL return. Reviewed-on: http://gerrit.openafs.org/8408 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 595a614d76d84be602c07d519738556b7f9ebf2a) Change-Id: Iba54fd03a63be485490db33ff48e5642f55df52d Reviewed-on: http://gerrit.openafs.org/9500 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 2f78e92f2f152526749e0f19211cb1231ad3e6c3 Author: Christof Hanke Date: Wed Aug 22 16:39:13 2012 +0200 fileserver: add volume number to error-messages in physio. If things go wrong in ReallyRead() or ReallyWrite(), the admin would like to know which volume to salvage. Reviewed-on: http://gerrit.openafs.org/8010 Reviewed-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 185699e631ec3548bb6d1e68302d4a652632d3e6) Change-Id: I0bc7fa31db17fc438e4c9852d685984747fb9b74 Reviewed-on: http://gerrit.openafs.org/9491 Tested-by: BuildBot Reviewed-by: Derrick Brashear Tested-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 1240f6dbb8de27174b58c56f99f9bd221c4de171 Author: Michael Meffie Date: Mon Apr 9 15:49:50 2012 -0400 libafs: log error code when marking server down Log the error code when marking the server down due to server/networks issues. Reviewed-on: http://gerrit.openafs.org/7138 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit f0b039fc4761bb0151c7ee69110926ef16e264c7) Change-Id: Ib66457a75006858b9523fa44c164859e8c8fae6f Reviewed-on: http://gerrit.openafs.org/9473 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 3f19ea5ffc3c56a342f8eb7f9c8b73eeca4d8aa6 Author: Andrew Deason Date: Thu Nov 10 11:05:28 2011 -0600 vol: Remove O_EXCL|O_TRUNC combinations A few places were specifying both O_EXCL and O_TRUNC to open(). O_TRUNC does not make any sense with O_EXCL, and doesn't do anything, so remove O_TRUNC from these instances to make the code more clear. Reviewed-on: http://gerrit.openafs.org/5832 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 4c679e380f697760de777d35fe057229bf2bf762) Change-Id: Iae79f552d17d626bbf2a7c9428bc9c7bbf91fae9 Reviewed-on: http://gerrit.openafs.org/9433 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 8f33982b230f87dac3856bea998015251ce2beec Author: Anders Kaseorg Date: Tue Mar 5 02:34:02 2013 -0500 afsd: afsd.fuse needs MT_LIBS This fixes a build failure on Ubuntu raring as of binutils 2.23.1-0ubuntu8, which pulled in a bugfix that makes --no-copy-dt-needed-entries stricter: http://sourceware.org/git/?p=binutils.git;a=commit;h=63f3bee644cc30f1e6d049ca54d307a7c63b8186 make[3]: Entering directory `/…/src/afsd' gcc -O -I/…/src/config -I/…/include -I. -I. -D_LARGEFILE64_SOURCE -I/…/src/afs -I/…/src/afs/UKERNEL -I/…/src/rx/UKERNEL -DUKERNEL -D_FILE_OFFSET_BITS=64 -I/usr/include/fuse -o afsd.fuse afsd_fuse.o /…/lib/libuafs.a /…/lib/libdes.a /…/lib/libafsutil.a /…/lib/libcmd.a /…/lib/libafsutil.a -lresolv -lfuse /usr/bin/ld.bfd.real: /…/lib/libuafs.a(afs_usrops.o): undefined reference to symbol 'pthread_setspecific@GLIBC_2.2.5' /usr/bin/ld.bfd.real: note: 'pthread_setspecific@GLIBC_2.2.5' is defined in DSO /lib/x86_64-linux-gnu/libpthread.so.0 so try adding it to the linker command line /lib/x86_64-linux-gnu/libpthread.so.0: could not read symbols: Invalid operation collect2: error: ld returned 1 exit status make[3]: *** [afsd.fuse] Error 1 make[3]: Leaving directory `/…/src/afsd' This is roughly a partial cherry-pick of commit f6d7a4b426f55db366113bbdda4da71570310410 (which doesn’t apply on 1.6.x), although this particular build failure had already been fixed on master as a side effect of commit 98f86cfc53fc987fdaed2f5bb733b5b5d21bfda9. Change-Id: I89467f00bbf511ec63c464b656d342c5fd2ce557 Signed-off-by: Anders Kaseorg Reviewed-on: http://gerrit.openafs.org/9387 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Stephan Wiesand Reviewed-by: Stephan Wiesand commit bf732d3e7a44bd8df5071714d0537024dc9d2517 Author: Jeff Blaine Date: Wed May 18 23:49:52 2011 -0400 Added -dryrun Added missing information about -dryrun option Reviewed-on: http://gerrit.openafs.org/4680 Reviewed-by: Jeffrey Altman Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 97070b425d4c6e4fa4944160c0e7a6965ebb8e75) Change-Id: I185f0d76a6c95dcffa01713798a06672e6f9bfa3 Reviewed-on: http://gerrit.openafs.org/9623 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit f5f50b9f31aa4eb86f53a085b01f13955434c80a Author: Simon Wilkinson Date: Fri Feb 22 10:23:43 2013 +0000 viced: Allow GetCapabilities to return an error At the moment, the GetCapabilities RPC handler ignors errors from CallPreamble or CallPostamble. Instead of silently swallowing these, and potentially reutnring a bogus capabilities structure, make it possible for the RPC to return failure to the caller. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9241 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman (cherry picked from commit ea0441520138d2129b5c6b2bd16c7640a8680146) Change-Id: Ic3828198e43403506f991455f09924387b483879 Reviewed-on: http://gerrit.openafs.org/9534 Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 5f983ae0b97fee5bd56bb939a5dc5a4fc78b44bc Author: Ben Kaduk Date: Fri Jan 11 13:03:02 2013 -0500 Catch up to FreeBSD KPI for vfs_cmount Almost a year ago, mckusick changed the VFS KPI/KBI for the cmount VFS operation, making the flags argument a 64-bit quantity. Introduce appropriate conditionals for our prototype of afs_cmount for the change on the 10.x and 9.x branches. Reviewed-on: http://gerrit.openafs.org/8907 Reviewed-by: Garrett Wollman Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 13111d25408cf6765d1b67bc3767614c8963cfde) Change-Id: I6e74760422f57336203d562dc4ee39ed2af0df84 Reviewed-on: http://gerrit.openafs.org/9406 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 1e515eb4c5436e387db6a9a72b97080500115f73 Author: Simon Wilkinson Date: Fri Feb 15 16:05:33 2013 +0000 rxgen: Fix NULL pointer dereference Avoid a NULL pointer dereference if strchr doesn't find any occurence of '*' in the string. Whilst we handle the not found case when inserting a mid string terminator, we don't handle it when restoring the string to its previous value. Reviewed-on: http://gerrit.openafs.org/9158 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 0d28f8c0cec91d68023795e6ba9c769d60869f9e) Change-Id: I6eb3ec5647153e588c5a80025da2bf2c921469b3 Reviewed-on: http://gerrit.openafs.org/9525 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Jeffrey Altman Reviewed-by: Stephan Wiesand commit e33bdad36bb96a2477f1511d82b597113919a11a Author: Simon Wilkinson Date: Fri Feb 22 10:20:58 2013 +0000 viced: Catch GetCellInfo failure If GetCellInfo returns a non-zero result, catch the error, rather than just carrying on regardless. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9240 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman (cherry picked from commit 1d1ba5f74102ae703ef657aa19150729edfe6ab2) Change-Id: I205b32a3e38faeae8e06bad3dc615ba01f0626d8 Reviewed-on: http://gerrit.openafs.org/9533 Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Reviewed-by: Derrick Brashear Tested-by: BuildBot commit 86c3a3b7ea14e06bd89eaccab51da12a9b7ed2a3 Author: Simon Wilkinson Date: Thu Feb 21 19:34:47 2013 +0000 Unix CM: Catch ICL initialisation failures If afs_icl_CreateLog fails, don't still call afS_icl_CreateSet. If afs_icl_CreateSetWithFlags fails, don't ignore its error code. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9203 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit 3bbff16c6d34c905fab8fcb792c8606ea356e2a8) Change-Id: I4835a6cbdc802bc08f5ae83fa10f9c93357cf736 Reviewed-on: http://gerrit.openafs.org/9532 Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Reviewed-by: Derrick Brashear Tested-by: BuildBot commit 8bd21b891f862a8754cf32cc6d85707cdfdb52fd Author: Simon Wilkinson Date: Fri Feb 22 09:51:24 2013 +0000 kauth: Don't ignore GetExtendedCellInfo failures Don't ignore a failure from afsconf_GetExtendedCellInfo, as it will leave buffers that we later read uninitialised. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9180 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman (cherry picked from commit 5cefa0247fe4f22f769e366a207fb177ee8fb94f) Change-Id: I613a371f1f0ab1a739966e81965661d6cbff8e5e Reviewed-on: http://gerrit.openafs.org/9531 Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Reviewed-by: Derrick Brashear Tested-by: BuildBot commit fff7c2fe29b5187a0c36441521d92c6513cdec88 Author: Ben Kaduk Date: Tue Feb 19 15:24:04 2013 -0500 FreeBSD version compatibility for 1.6.x This is a direct commit, not a cherry-pick, as the libafs build is different for master and the 1.6 branch. Instead of needing to always play catch-up, reverse the sense of the conditional and specifically exclude the FreeBSD 5.x and 6.x versions so that new versions will automatically be in the right conditional. Change-Id: Ifa1d4004faab8a7d6a94ca8d5aeff90e4c51b88e Reviewed-on: http://gerrit.openafs.org/9143 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 977a7b060d1fcf289ad74d7d59edbb8b22ebfedd Author: Andrew Deason Date: Mon Sep 24 14:20:07 2012 -0500 doc: Fix Solaris 11 kernel module path For Solaris 11, the module goes in drv, not fs. Reviewed-on: http://gerrit.openafs.org/8152 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Ken Dreyer (cherry picked from commit a7278eb5620507cd70086582cf539b4024b46194) Change-Id: Idb5f864132f436f9a6cc619d1c672c9ceec3ff67 Reviewed-on: http://gerrit.openafs.org/9566 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 3a51648fb500680934498730f3ed9b2bbd24b745 Author: Michael Meffie Date: Fri Sep 21 15:58:29 2012 -0400 doc: solaris x86 kernel module path Add instructions for solaris x86 kernel module installation. Reviewed-on: http://gerrit.openafs.org/8143 Reviewed-by: Ken Dreyer Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit 5ef5cf48f3d2ba52cf5ed428728215b5b5f8d0b2) Change-Id: I7bec3361b5f9e47c8b3cfbfbe27e012288ec9780 Reviewed-on: http://gerrit.openafs.org/9565 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 392b1c6b4c10e18e608f04513ba7b82220f74cc1 Author: Michael Meffie Date: Tue Apr 10 16:07:37 2012 -0400 doc: distributed files are under dest Add the dest path component in the quick start guide instructions for copying files from a binary OpenAFS distribution file. Reviewed-on: http://gerrit.openafs.org/7187 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit bc770a5007ae16aa5477bf1748f3e0666f665781) Change-Id: I54c96f35ce4f9c60a25fee012306ecb210972287 Reviewed-on: http://gerrit.openafs.org/9564 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 73fa4ef44dd763da0f4ba067a0b53892934a0922 Author: Michael Meffie Date: Fri May 20 13:53:48 2011 -0400 doc: document volinfo -filenames option Add the namei -filenames option to the volinfo man page. Note this option as implemented implies the -vnode flag, but for consistency with the other fields that modify the default mode output, it is documented to be accompany the -vnode flag. Reviewed-on: http://gerrit.openafs.org/4690 Tested-by: BuildBot Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear (cherry picked from commit e3fb2740ba20e78fdc93308b6a2843454a6d269c) Change-Id: I1ef65090d5449f600ef03171436a27c142e69fbb Reviewed-on: http://gerrit.openafs.org/9563 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 7f5856342961540f46b9012cda12b144d5256274 Author: Simon Wilkinson Date: Sun Feb 24 12:53:59 2013 +0000 budb: Store dumper information correctly Change f498c18a6f7300eb89ca3b9d9b85c4d461fa8474 attempted to fix a problem with using an inappropriate function to copy the ktc_principal value 'principal' into the d.dumper structure element. Originally the code read: principal_hton(&principal, &d.dumper) which copies the 'host' principal principal into the 'net' structure d.dumper. However, this was changed to principal = d.dumper Which populates 'principal' with whatever garbage is in the d.dumper structure. Fix this so that the assignment is done the right way around. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9252 Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit dce2d8206ecd35c96e75cc0662432c2a4f9c3d7a) Change-Id: Ib3851649293bddedf465739acc9bd7ad327c80e0 Reviewed-on: http://gerrit.openafs.org/9537 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 2b14a3b290b7f459edb426fa70b18c14e369596e Author: Simon Wilkinson Date: Sun Feb 24 10:43:52 2013 +0000 budb: Fail if afsconf_GetExtendedCellInfo does Rather than silently ignoring the failure of afsconf_GetExtendedCellInfo, and then using garbage cell configuration, just fail to start if afsconf can't parse the config directory. Reviewed-on: http://gerrit.openafs.org/9247 Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 3fbdc609dc025cfcaac6949485d6fb072bf34764) Change-Id: I40f0aefda1bc44ce92a7733ec644002229c32079 Reviewed-on: http://gerrit.openafs.org/9536 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 489bb387a35f14ae94ba73ec395f51c5bdfd0b7a Author: Simon Wilkinson Date: Sun Feb 24 10:39:53 2013 +0000 butc: Catch failures to start keep alive thread If we can't start the keep alive thread, in either the LWP or pthread versions of a code, report an error and exit instead of carrying on regardless. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9245 Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit e4862e284832420e9dbf5a6f437f6f7c8801f7dd) Change-Id: I55453557b592bb1814877d291b1604907ab2e8d6 Reviewed-on: http://gerrit.openafs.org/9535 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 2327f5fd3a250c14f5367f93a975573a04e04655 Author: Simon Wilkinson Date: Thu Feb 21 22:10:38 2013 +0000 Unix CM: Fix bogus character in license string A stray $ had crept into the license string in afs_dcache.c. Fix it. Reviewed-on: http://gerrit.openafs.org/9233 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear (cherry picked from commit 983d67616b670c5d57c8c67578fdb52f2bb3ddbd) Change-Id: I21d31dc9e50e6be253cc7e7878e1079567f10220 Reviewed-on: http://gerrit.openafs.org/9529 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 9b3f4d8be8b7b9c7760abf982b9ed12bc457b66e Author: Simon Wilkinson Date: Tue Feb 19 15:43:29 2013 +0000 ptserver: Don't ignore ubik_Write failures If we can't write to the ubik database, then that's a bad thing. Don't ignore it. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9176 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit 860c34ba938602387f78c10c2f548fb8a523a9cd) Change-Id: Id379d94844e6cc520829b4ef6015d0a004fdbc42 Reviewed-on: http://gerrit.openafs.org/9526 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 85fade41f2fca7eefa1efff770d6173aef4d9158 Author: Michael Meffie Date: Sat Jan 5 13:37:51 2013 -0500 correct whitespace errors in readme files Fix the trailing whitespace and leading spaces before tabs in the readme files. Reviewed-on: http://gerrit.openafs.org/8877 Tested-by: BuildBot Reviewed-by: Michael Meffie Reviewed-by: Ken Dreyer Reviewed-by: Jeffrey Altman (cherry picked from commit 8a17568fb4fd3f77a3b9d043bbe49e992bca8266) Change-Id: I60fb4d05cf79f4998e8652026dc3f1f636bcd6a4 Reviewed-on: http://gerrit.openafs.org/9518 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 6751327f6f7ba1389c6caf1207abe78e9cdb0d70 Author: Nickolai Zeldovich Date: Sat Jan 5 23:44:55 2013 -0500 ubik/udebug.c: check array index before dereferencing Avoid out-of-bounds array accesses by first checking that the index is in-bounds, and then dereferencing; not the other way around. Reviewed-on: http://gerrit.openafs.org/8879 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: BuildBot (cherry picked from commit 0e83cde60e6e91fbe20ffac0f0a77afe8497d950) Change-Id: I7a5018011939d43b702c63a272d53a2018df7d33 Reviewed-on: http://gerrit.openafs.org/9513 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit dc8952ff29584a8bbc7be66a53f6c4fffd3178f3 Author: Jeffrey Altman Date: Tue Jul 3 15:58:01 2012 -0400 viced: RXAFS_GetVolumeStatus remove access check The AFS file server had always performed a PRSFS_READ permission check on the volume's root directory (1.1) vnode before responding succesfully to the client. A successful response contains the following volume state information: Message of the day (if any) Offline message (if any) Online flag InService flag Blessed flag NeedsSalvage flag Type MinQuota MaxQuota BlocksInUse PartBlocksAvail PartMaxBlocks All of this information is publicly available to anonymous users via other services so it is odd that it is hidden from anonymous cache managers. As sites begin to tighten the ACLs on volumes due to privacy and security concerns this READ permission check is begin to cause problems for Windows clients that rely upon the quota and block counts to determine whether or not it is likely to be safe to perform an extending write. In many environments volumes are being configured such that the root directory is 'l' for all and only the subdirectories provide for 'ridw'. Under these situations the user is able to read/write the data but cannot determine how much free space is available. Since all of the data returned by RXAFS_GetVolumeStatus is publicly available, the patchset removes the access check entirely. Reviewed-on: http://gerrit.openafs.org/7705 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit d2d591caf2c9b4cf2ebae708cc9b4c8b78ca5a5a) Change-Id: I94886f2325ee46995dd886bbf2d359f6d3af76fe Reviewed-on: http://gerrit.openafs.org/9489 Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand Reviewed-by: Derrick Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Tested-by: BuildBot commit 35108215d98ef78c9bf54cb66597c53f3d03164f Author: Simon Wilkinson Date: Fri Feb 15 22:34:36 2013 +0000 libadmin: Don't try to release garbage connection In bos_ServerOpen, initalise the contents of bos_server structure to 0 using calloc, so that if we jump to the error handling stuff before they are assigned real values we don't end up trying to release garbage. Reviewed-on: http://gerrit.openafs.org/9163 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear (cherry picked from commit 17154a3c0afa88f7bb25e2b642fc13ee69c2b7db) Change-Id: Iaa6e5166cb29799feb82ca29ef3e78ceea82d6e2 Reviewed-on: http://gerrit.openafs.org/9524 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 0671633b59ac8fd1d2fe54c65a516aa518fbca83 Author: Andrew Deason Date: Mon May 21 18:15:58 2012 -0500 afsd: Report fakestat correctly A fakestat value of 1 is for -fakestat-all, and 2 is for -fakestat, not the other way around. Reviewed-on: http://gerrit.openafs.org/7445 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 47e12584804b287051552900c94c99a3c84daa92) Change-Id: I8b0872430c771741962afcfd9854cbe5fcdc42e8 Reviewed-on: http://gerrit.openafs.org/9478 Reviewed-by: Stephan Wiesand Reviewed-by: Derrick Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Tested-by: BuildBot commit c1bc649cefc37aa4fb2546b648ba917a4fb1b897 Author: Mark Vitale Date: Thu Feb 14 10:51:34 2013 -0500 salvager: incorrect comment The comment for the code handling the -showsuid option was incorrect. Reviewed-on: http://gerrit.openafs.org/9109 Reviewed-by: Jeffrey Altman Tested-by: BuildBot (cherry picked from commit 4051c5e96e921b69ac2a6e7bcb805cbc0a8f7993) Change-Id: Id19e063c9540e362b4d9478a0fce606084d470e6 Reviewed-on: http://gerrit.openafs.org/9523 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit f8d05579128f953b870cd3f4d9a0ffbe9d7287dd Author: Thorsten Alteholz Date: Wed Jan 30 20:11:04 2013 +0100 fix some typos in bos_setrestricted the real name of the command is: 'bos setrestricted' it is sufficient to name 'bos install' only once Reviewed-on: http://gerrit.openafs.org/8990 Reviewed-by: Ken Dreyer Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear (cherry picked from commit 69f634503482f899e4d422b16100636905c72ea8) Change-Id: I7ab452cb2cf5e836341f7fc66dacd317cf65ed58 Reviewed-on: http://gerrit.openafs.org/9521 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 69ef35ac1417ddba2d292bc22df9f54305ba9da1 Author: Chas Williams (CONTRACTOR) Date: Wed Jan 16 21:16:31 2013 -0500 LINUX: fix array indexing issue in memory statistics The comma is a sequence point and i gets incremented and then used. This results in writing past the end of the array by one (and failing to initialize the first element as well). Potential fix for RT ticket 131566. Reviewed-on: http://gerrit.openafs.org/8914 Tested-by: BuildBot Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear (cherry picked from commit 04ddecc1f2827463edf22857f9b19910ccc25e98) Change-Id: I09a96fcb5ffc9a58f0930f76e4ee5f65628ba5c8 Reviewed-on: http://gerrit.openafs.org/9520 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit d0418efd8edc60979ee7983b81437b5a467732e9 Author: Nickolai Zeldovich Date: Sat Jan 5 23:45:59 2013 -0500 libadmin/vos/vosutils.c: mask out sign-extension Right-shifting a signed int by 24 bits can produce a value outside of 0..0xff due to sign-extension. As a result, in AddressMatch(), the first bPattern!=255 check can never succeed. Fix by masking with 255 before comparison. Reviewed-on: http://gerrit.openafs.org/8884 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: BuildBot (cherry picked from commit 8e8e3c26b87d78b92d96ba91d58ee59d774ebcb5) Change-Id: Ifee303905d004936e96f6be1e6a9188d7b70978c Reviewed-on: http://gerrit.openafs.org/9517 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit bfe9b6a8d384739cfe98fcc54bdb55a894cc9d0c Author: Nickolai Zeldovich Date: Sat Jan 5 23:45:46 2013 -0500 lwp/iomgr.c: avoid off-by-one out-of-bounds access Avoid accessing sigDelivered[NSIG] and sigEvents[NSIG], which are out-of-bounds by one. Reviewed-on: http://gerrit.openafs.org/8883 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: BuildBot (cherry picked from commit bd850e5b980d34236ee98d16b9717860b63af306) Change-Id: I859c654b8d35484aeeb029432c69848846335fb8 Reviewed-on: http://gerrit.openafs.org/9516 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit bba18139f27169bd9040c43db29955399a419695 Author: Nickolai Zeldovich Date: Sat Jan 5 23:45:33 2013 -0500 butm/file_tm.c: check for null pointer before dereferencing Move the null pointer check to before the pointer is dereferenced. Reviewed-on: http://gerrit.openafs.org/8882 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: BuildBot (cherry picked from commit 4d6967e0b0a0628deb1dd9d210de84779d41f856) Change-Id: Ib6c9308170b1242ea207f5380275d51b1514028d Reviewed-on: http://gerrit.openafs.org/9515 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 8a6b943b3f057f5e7995d9687ddc9574f3e55ddc Author: Nickolai Zeldovich Date: Sat Jan 5 23:45:11 2013 -0500 src/tests/pathname.c: properly check strdup() return value Fix the check for strdup() running out of memory. Reviewed-on: http://gerrit.openafs.org/8880 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: BuildBot (cherry picked from commit d9cc9c9dee9ad0213ddd39174e81d01b9707937b) Change-Id: I56dc0dd7ced4df5be636a03db819169b5413e56b Reviewed-on: http://gerrit.openafs.org/9514 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 0e367d2eb72e1ea80c04378d837468e0cbaf1a7e Author: Nickolai Zeldovich Date: Sat Jan 5 23:44:33 2013 -0500 volser/vol_split.c: do not dereference known-NULL pointer Avoid dereferencing a pointer that we just checked is NULL when printing an error message. Reviewed-on: http://gerrit.openafs.org/8878 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 5c5515a5c3b34f9a115b29378e123c779c138f51) Change-Id: I73de73f8cd9be9d106285f45e86e030909293521 Reviewed-on: http://gerrit.openafs.org/9512 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit ff77c3a190b0271381d9f79e260f806befbafeee Author: Simon Wilkinson Date: Fri Mar 30 19:31:10 2012 +0100 vol: Call memset with the correct size Call memset with the size of the structure we're initialising to 0, and not the size of the pointer to that structure. Caught by clang's new warnings. Reviewed-on: http://gerrit.openafs.org/7083 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 408afc5690fc8ac3b6942983765ab36e63d2534d) Change-Id: I25fd235ffd7478295bf205b232ecc5816f962d3f Reviewed-on: http://gerrit.openafs.org/9472 Reviewed-by: Derrick Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit 1eb75c9bc7cba880936f4cb9a35399051314897c Author: Michael Meffie Date: Tue Nov 20 08:49:39 2012 -0500 tools: example sysvmq audit reader A user contributed sysvmq audit log example reader. Shows how to read the sysvmq audit log using core only perl modules. Reviewed-on: http://gerrit.openafs.org/8485 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 7c8373c8c27abdfa316c6526aa14654caed3e7f8) Change-Id: Ib2eb66763e6ada884f33f14fbe950759fc9c3c43 Reviewed-on: http://gerrit.openafs.org/9501 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 0c6b8c13ce38de628bddc9e17232b4900c661091 Author: Marc Dionne Date: Fri Sep 21 20:08:58 2012 -0400 bozo: fix typo in help text Fix a typo for "interface" in the help text for bosserver. Reviewed-on: http://gerrit.openafs.org/8144 Reviewed-by: Ken Dreyer Tested-by: BuildBot Reviewed-by: Jason Edgecombe Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear Reviewed-by: Michael Meffie (cherry picked from commit 58c089e642198a210462b3bf508056b56667f879) Change-Id: I90fff6c691ae59ff467a641cb025cedc17a3bb4c Reviewed-on: http://gerrit.openafs.org/9498 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit a3f495b66431773d44a04be14b09d71cb3921d82 Author: Andrew Deason Date: Tue Sep 11 18:46:42 2012 -0500 rx: Save errno in LWP rxi_Sendmsg Much of this code examines errno or WSAGetLastError to determine what to do. However, some other operations between the actual sendmsg call and code that examines errno may modify errno. So, save the value of errno to ensure errno reflects the actual error we got from sendmsg; this also slightly simplifies some of the logic. Reviewed-on: http://gerrit.openafs.org/8110 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit 347908cd0031c558c266ec412aa49200ae2b3204) Change-Id: Ia0134acb2ae5f9e47fb82f36bd0889987803d897 Reviewed-on: http://gerrit.openafs.org/9496 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Tested-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand commit 72ce52692f388587cbccc29180e0bd3f47d70cc8 Author: Andrew Deason Date: Wed Jun 20 16:28:51 2012 -0500 vos: Avoid creating volume with the same RO/BK ids If we specified an RW id of 5, an RO id of 6, and no BK id, this code would assign the BK id to RW+1, or 6. This gives the RO and BK volumes the same volume id, which is a mistake. Choose a different id instead. Reviewed-on: http://gerrit.openafs.org/7603 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 234bedae6ef506ec1ff53854a22548e892db3f11) Change-Id: I332fed5b8cac23a847a8890188f899cff909f130 Reviewed-on: http://gerrit.openafs.org/9488 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Benjamin Kaduk Reviewed-by: Stephan Wiesand commit d87fdb50db5c306973f4f379e82d992d18244c34 Author: Marc Dionne Date: Thu Sep 22 19:09:52 2011 -0400 viced: fix incorrect error message The error message was obviously copied from another location in the code (after the pr_Initialize call) and is misleading. Adapt it for vl_Initialize failure. Reviewed-on: http://gerrit.openafs.org/5490 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit a020c572d372f2e86807dc4c75ec50ff14ef2fba) Change-Id: I067ceb0e5e2281508647065f11e48d4a07033c99 Reviewed-on: http://gerrit.openafs.org/9432 Reviewed-by: Derrick Brashear Tested-by: Andrew Deason Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 2fa8aebb40c8884994ed6089a4b38cc73930cc79 Author: Marc Dionne Date: Tue Sep 13 19:32:37 2011 -0400 vos: print correct command name in diagnostics for changeloc Fix the label in the diagnostics message, it prints "addsite" instead of "changeloc" when an error occurs during vos changeloc Reviewed-on: http://gerrit.openafs.org/5414 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman (cherry picked from commit 1de4561529bdb92b6647a634d9f2c2714e1758e5) Change-Id: If87fd2a1ed0d4c2975479b5167f6e867db62437a Reviewed-on: http://gerrit.openafs.org/9431 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit ab07b2f8b279570177169364aeb6842dc4614fd2 Author: Simon Wilkinson Date: Thu Feb 28 10:22:43 2013 +0000 ptuser: Clear return value from pr_ListMembers Make sure that lnames is zero'd on entry to pr_ListMembers, so that an early error return doesn't also return garbage. Reviewed-on: http://gerrit.openafs.org/9309 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit bc70828f0713891597cf0042bc3e204f3d923271) Change-Id: If99abc35f49ac1d436fbb82c1f9dbf97590e95c5 Reviewed-on: http://gerrit.openafs.org/9379 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit 81aee1540534350bc33826bf207c7ee1df147f63 Author: Simon Wilkinson Date: Thu Feb 28 13:45:00 2013 +0000 Unix CM: Don't overflow ICL logs array When checking whether a user supplied index into the ICL logs array is out of bounds, we need to check whether it is greater or equal to the maxmimum number of elements. Otherwise we can access one more than the number of elements in the array. Caught by coverity (#985567) Reviewed-on: http://gerrit.openafs.org/9311 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit ff8bae8938532d95f792258d2c520705e095e7af) Change-Id: I5dba0d22d4589cb7d1f0a4fe57623646d300ab61 Reviewed-on: http://gerrit.openafs.org/9378 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit d8c76c472a4d85c8d30de6ea4f02e4b3aeb07945 Author: Simon Wilkinson Date: Fri Mar 1 10:54:07 2013 +0000 Unix CM: Fix stray semicolon Commit d2437d02a6f59d972dd0690f7eb1c46cf7cc4b85 introduced a stray semicolon in the osidnlc code. Fix it. Caught by coverity (#989030) Reviewed-on: http://gerrit.openafs.org/9321 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit 59def405ba9404954debd35da539346b1ccd4096) Change-Id: I35256e7b0aec95b3341db9cd1e99387b1050fab4 Reviewed-on: http://gerrit.openafs.org/9377 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit 0c1815b37a27a609892a553005da2305a5779a1e Author: Simon Wilkinson Date: Thu Feb 28 15:26:15 2013 +0000 Unix CM: Fix hash table overflow in dnlc code In GetMeAnEntry, we can end up overflowing the nameHash array by one element if the stars are particularly badly aligned. nameptr is a static across function calls, so nameptr and j are not equal. If nameptr is increment to NHSIZE in the same loop iteration as j reaches NHSIZE + 2, the loop will terminate. We'll then lookup nameHash[NHSIZE], which is 1 element passed the end of the array. Add an if statement which loops nameptr outside the loop (in the same way as the if statement in the loop) Caught by coverity (#985568) Reviewed-on: http://gerrit.openafs.org/9312 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit d2437d02a6f59d972dd0690f7eb1c46cf7cc4b85) Change-Id: Ic19d72e6c012cb06e98c3c970162995e77da4b68 Reviewed-on: http://gerrit.openafs.org/9376 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit 393043f6dbfdd684b14281fbe568c14c0e11a15c Author: Simon Wilkinson Date: Fri Mar 1 11:22:26 2013 +0000 kauth: Don't overflow cellinfo hostAddrs array The hostaddrs array has MAXHOSTSPERCELL (8) available elements. The ubik connections list has MAXSERVERS (20) elements - when copying from the ubik list into the cellinfo hostaddrs list, be careful not to overflow it. Caught by coverity (#985577) Reviewed-on: http://gerrit.openafs.org/9323 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit 30e25c74376dd8aa24018116015e57c47c1dfaf9) Change-Id: I6bf03fada98cf6f5442a7d6a1e52e18cc91aad59 Reviewed-on: http://gerrit.openafs.org/9375 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit d3dca0b7dd7874dee01065e04eccd68a63fc1493 Author: Simon Wilkinson Date: Fri Mar 1 11:31:31 2013 +0000 unlog: Don't overflow cells array cells has a maximum size of MAXCELLS. Doing cells[MAXCELLS] overflows that array. Clamp our maximum number of cells at one below this to avoid the overflow. Caught by coverity (#98551) Reviewed-on: http://gerrit.openafs.org/9324 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit ff7fd58b49a41bf85df492b9f470004d4433800e) Change-Id: If6c0caed4b4fedf571c4c6c6b8466bfaaff67975 Reviewed-on: http://gerrit.openafs.org/9374 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit 9fc38b1bcdfd7c16fc84f88314d7b9ec0f084b18 Author: Simon Wilkinson Date: Fri Mar 1 11:47:03 2013 +0000 ubik: Don't overflow server's addr array We're checking to see if we've overflowed the array _after_ we've looked up an element within it - so on the final iteration, we always read past the end of the array. Fix this by swapping the order of the tests in the for statemen Caught by coverity (#985590) Reviewed-on: http://gerrit.openafs.org/9326 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit a4ae9a4c3cc1fa5ca2b813174040dce36284a4b9) Conflicts: src/ubik/recovery.c Change-Id: Ic09177a1e85492e181e51d554ddb25df2ca2dfbd Reviewed-on: http://gerrit.openafs.org/9373 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit 486ba708442aa7296503dc44f2c2662ed784725f Author: Simon Wilkinson Date: Fri Mar 1 12:01:19 2013 +0000 util: Fix overflows in address parsing The extractAddr function (which turns a dotted quad into an IP address), has a number of overflows when one or more elements of the quad are more than 31 characters in length. The array allocated for each portion is 32 bytes long, but we only stop writing into the array when the indexing pointer reaches 32, which doesn't leave us with space for the trailing NULL. Rework this so we always allow space for the NULL, and use a #define for the array length to make it more clear whats going on. Caught by coverity (#985591, #985592, #985593, #985594) Reviewed-on: http://gerrit.openafs.org/9327 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit 28a441ebd8323437bf762a790b4ec5e6301e4bec) Change-Id: I9506fd8b468c957f0c9f8dc2d58baf5bc6bc2e19 Reviewed-on: http://gerrit.openafs.org/9372 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit c73b6b61f62e966d8ca962d943b99b26fd441e26 Author: Simon Wilkinson Date: Fri Mar 1 12:12:07 2013 +0000 up: Fix improper use of readlink readlink returns a non-NUL terminated string. If the string must be terminated, we need to have space in the buffer for it. So, the buffer passed to readlink must be 1 less than the real length of the buffer. Caught by coverity (#985597, #985610) Reviewed-on: http://gerrit.openafs.org/9329 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear (cherry picked from commit 80875f8aa1540bf032073a4843566bbe6b1fe301) Change-Id: I1dd039bfceaff7891c9145cf4799469b2de2f23a Reviewed-on: http://gerrit.openafs.org/9371 Reviewed-by: Andrew Deason Tested-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit 77249c3a549865565b15456cd511a690f127d163 Author: Simon Wilkinson Date: Tue Feb 26 12:38:59 2013 +0000 volser: Catch EOFs when reading dumps When reading a standard tag, make sure and catch an EOF error from iod_getc. Otherwise we'll end up trying to parse 0xFF as a tag length. Caught by coverity (#985603) Reviewed-on: http://gerrit.openafs.org/9275 Reviewed-by: Derrick Brashear Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Jeffrey Altman Tested-by: BuildBot (cherry picked from commit cc703d9562455c74767fcd6d2055339109fa9243) Change-Id: I29957f7b656bb2cdd19601d90990d7bacd82e98c Reviewed-on: http://gerrit.openafs.org/9361 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Paul Smeddle Reviewed-by: Benjamin Kaduk Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 4e9e404dea8f0d07714f8ba668735ac0999d7934 Author: Simon Wilkinson Date: Wed Feb 20 14:54:55 2013 +0000 volser: Make it clear what's copied from partList XVolListPartitions uses partList to maintain a list of partition IDs - it does not use the partFlags field. Make it clear when we populate the partEntries field that we are only copying the partition list. Caught by coverity (#986030) Reviewed-on: http://gerrit.openafs.org/9262 Reviewed-by: Jeffrey Altman Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 00601179625ffb71461bbcc46629791895cf4793) Change-Id: I878011efe4baae897e5d4f875c8e02378da38587 Reviewed-on: http://gerrit.openafs.org/9360 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Paul Smeddle Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 3073ca05ecef5a2c832e92a072e5b430fb40cef9 Author: Simon Wilkinson Date: Tue Feb 26 12:17:29 2013 +0000 viced: Don't write out garbage when extending file When we extend a file, we write a single byte of data to it - tlen is used as a source for this single byte. However, in the current code, tlen is used uninitialised. Set it to 0, so we don't write a byte of stack garbage. Caught by coverity (#986015) Reviewed-on: http://gerrit.openafs.org/9271 Reviewed-by: Derrick Brashear Reviewed-by: Chas Williams - CONTRACTOR Tested-by: BuildBot (cherry picked from commit e191cb889c941848fe09f04c24d969111e6dc494) Change-Id: I517b5772241314a0854094655e25f3f75eba90d1 Reviewed-on: http://gerrit.openafs.org/9358 Tested-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit 19e427070fd14447658777cc572aab75f8fdc949 Author: Simon Wilkinson Date: Tue Feb 26 12:21:59 2013 +0000 ubik: Zero header before writing to disk The ubik disk header contains a padding field, which is never zeroed before being written out to disk. This means that there is a shorts worth of stack garbage in every ubik label! Just zero the whole structure with memset before we populate it. Caught by coverity (#986011) Reviewed-on: http://gerrit.openafs.org/9272 Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit d8fa251a14e9469fb6ec722d100b6a8557248694) Change-Id: I1d3baf4ced6583f22458155edcc16344acc5757e Reviewed-on: http://gerrit.openafs.org/9357 Reviewed-by: Jeffrey Altman Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit 36e1707ffbda22808cf5af23460dd05c38a6a87a Author: Michael Meffie Date: Mon Dec 10 12:01:38 2012 -0500 doc: dynamic mount requires dynroot and fakestat Document that dynamic mount (/afs/.:mount) requires dynroot and fakestat on non-linux unix. Reviewed-on: http://gerrit.openafs.org/8739 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear Reviewed-by: Ken Dreyer (cherry picked from commit 7dbb35a89f42743ff0a29bc9822b94141a2a8323) Change-Id: Ia77835cd1830c7bc5dde573f2e890341aa06bc21 Reviewed-on: http://gerrit.openafs.org/9519 Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: BuildBot commit af1888ff142763fc7ec8d10b9bc24e49669c1178 Author: Antoine Verheijen Date: Mon Jan 21 02:30:58 2013 -0700 OpenBSD: Replace "vnodeop_desc" with "vops" in kernel module. In OpenBSD 4.9, the vnode operations vector in the "vnode" struct was changed from using a "vnodeop_desc" struct to a new "vops" struct. This patch makes the appropriate changes to the OpenBSD kernel module support to accommodate the change. Reviewed-on: http://gerrit.openafs.org/8928 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit bb42c02ce56aec29e3860bec47e47157d0406f20) Change-Id: I768358758763a362c92351211bda6d8a7eab6a26 Reviewed-on: http://gerrit.openafs.org/9595 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Stephan Wiesand commit 0ba3e7521c9b091b81f75ccb2fe06dcfc3743f43 Author: Michael Meffie Date: Sat Jan 5 10:40:42 2013 -0500 spelling corrections in readme files Fix spelling errors in readme files. Reviewed-on: http://gerrit.openafs.org/8876 Tested-by: BuildBot Reviewed-by: Ken Dreyer (cherry picked from commit 4042667388406e540c8a6546031d514793ffc8c4) Change-Id: Idd64293533af373c2b467049442231bb85b6d7db Reviewed-on: http://gerrit.openafs.org/9511 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 93bfb96b3a62bad5805d7fab93e61cee6b7f1e27 Author: Michael Laß Date: Sat Dec 22 22:54:20 2012 +0100 Remove AFSLore from wiki URLs The URL of the openafs wiki doesn't contain "AFSLore" anymore. Although these old URLs still work, replace them to point users to the correct address in the first place. Also be consistent and always use a trailing /. Reviewed-on: http://gerrit.openafs.org/8819 Reviewed-by: Ken Dreyer Reviewed-by: Chas Williams - CONTRACTOR Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman (cherry picked from commit df4d971ec1a014826929dfeac017fb24d37ac38a) Change-Id: I99027c23c3a2e5604f927f51961298b5ec27d1c1 Reviewed-on: http://gerrit.openafs.org/9504 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Michael Laß Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit c629ab8faef2cde90219f56542a0a72c42e206e8 Author: Jeff Blaine Date: Sun Jun 5 16:38:53 2011 -0400 Remove completed tasks from todo list, add info about git/gerrit preference Removed completed tasks (fstrace subcommand help in-binary and issue with -noexecute vs. -dryrun in vos delentry) from todo list. Added info about git/gerrit preference for documentation help, but patches still allowed to the openafs-doc list. Reviewed-on: http://gerrit.openafs.org/4803 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit 8f186c0f7a48059ca561422d58073e22934ea2dc) Change-Id: Iec6e3db185e816f6c1b587cc74cc5ca5a2c93282 Reviewed-on: http://gerrit.openafs.org/9503 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit d76971a08a8a0fb92cbd1b5951bd8798eda3873c Author: Andrew Deason Date: Wed Nov 10 15:21:07 2010 -0600 afscp: Always show fetch/store errors When we get an error from a fetch or store operation, show what the error was, instead of just saying "some network error occured". Reviewed-on: http://gerrit.openafs.org/3290 Tested-by: BuildBot Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear (cherry picked from commit 8078c4dcf2dd5a922225f0e37babf1b357b5e72d) Change-Id: Icfdce08149e16749097bd6be326312dec6292d34 Reviewed-on: http://gerrit.openafs.org/9415 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 2cf573da487b43e50cfc283fdd03374279d153c3 Author: Andrew Deason Date: Sun Nov 21 21:40:28 2010 -0500 afsd: Remove unused definitions Remove some #defines for s_host and similar things. They are not used anywhere, and they can cause warnings for e.g. s_host being redefined. Reviewed-on: http://gerrit.openafs.org/3364 Reviewed-by: Derrick Brashear Tested-by: BuildBot (cherry picked from commit be6fb658fe717469470bcd28c46bee1901c4d96c) Change-Id: I9ca3c81dde7321928c96a80ae46ff9b736c1040e Reviewed-on: http://gerrit.openafs.org/9413 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Tested-by: Stephan Wiesand commit 96385ddaee0cc31c0ea7e5e9a900a7e58891f82c Author: Ben Kaduk Date: Tue Feb 19 13:06:36 2013 -0500 butc: do not use stack garbage for secobj The butc only ever handles connections over rxnull anyway, so just specify an array of security objects of length one. Reviewed-on: http://gerrit.openafs.org/9140 Tested-by: BuildBot Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear (cherry picked from commit 252a5b65c30636bf5f62a49a79e5777004ecd17d) Change-Id: I0b5c112f56553b7ee0ea4e40a9c65f2fe45f8297 Reviewed-on: http://gerrit.openafs.org/9404 Reviewed-by: Jeffrey Altman Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit ecb50e7989f7f197f69873780d71f0ea22a1e7bd Author: Derrick Brashear Date: Mon Feb 25 14:56:37 2013 -0500 afsutil: fix prototype the prototype for afs_config_get_string was broken. fix it. 1.6 fix only; on master, hcrypto provides this Change-Id: Id7f877c197e44437fe41cb89630ce6e1bf2d6e3d Reviewed-on: http://gerrit.openafs.org/9362 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand commit 8f5c475895542ce119c346bd4a6926f8bf05ccf8 Author: Andrew Deason Date: Thu Mar 7 13:52:25 2013 -0600 tbudb depends on libafsauthent budb_server in src/tbudb requires libafsauthent to build. So, make tbudb depend on libafsauthent. This is a 1.6-only change. On master, tbudb no longer uses libafsauthent. Change-Id: I0737f455323589c28a78d680c6c09fcbcb99d302 Reviewed-on: http://gerrit.openafs.org/9456 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk Tested-by: Stephan Wiesand Reviewed-by: Stephan Wiesand commit 07b2f0e218f2a2fca4eaef19f364e74c16a48e92 Author: Ben Kaduk Date: Wed Mar 6 13:51:15 2013 -0500 Only have one build rule for budb_errs.c This commit squashes two cherry-picks from master together, as the first one broke the build with pthreaded ubik enabled. The first commit: Author: Simon Wilkinson Date: Mon Feb 21 00:29:33 2011 +0000 budb: Only have one build rule for budb_errs.c budb had two build rules that could produce budb_errs.c, but only one of them also produced budb_client.h. This led to problems with parallel makes, as depending on which rule fired first, budb_client.h might, or might not, exist. Rework all of this so that it's cleaner. Instead of producing two copies of the error table, just make budb_client.h a static file, and include the dynamically generated budb_errs.h from it. This reduces code duplication, and means that we have to run compile_et one less time. Reviewed-on: http://gerrit.openafs.org/4027 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear (cherry picked from commit 0d0b5048a5b68d4079b13609775f9234183d1947) The second commit: Author: Andrew Deason Date: Mon Feb 21 13:49:59 2011 -0600 Fix budb build rules for tbudb and WINNT Commit 0d0b5048a5b68d4079b13609775f9234183d1947 only fixed the budb Makefile.in. Make the analagous changes to tbudb/Makefile.in and NTMakefile. Reviewed-on: http://gerrit.openafs.org/4029 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 61453d8f33f6508f8464ffba0657aefb6c7eae3b) Change-Id: I7d35c7557bcd82ba50742f2594bd4bb78cf0e5a5 Reviewed-on: http://gerrit.openafs.org/9405 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Andrew Deason Reviewed-by: Paul Smeddle Reviewed-by: Stephan Wiesand commit 2a474f0284301151ea7342c658b08e17a7afed42 Author: Simon Wilkinson Date: Thu May 19 18:56:27 2011 +0100 vlserver: Use correct memsets in vlentry convertor The various vlentry_to_ conversion functions have obviously been copy and pasted from each other. However, the size of the structure which is being zeroed has not been updated when we are zeroing different structures. Fix this, so that we always clear all of the structure that we are filling. Change-Id: Ic822e1d2b17494574074c332c7680e94d4701c66 Reviewed-on: http://gerrit.openafs.org/4773 Tested-by: BuildBot Reviewed-by: Derrick Brashear (cherry picked from commit 90507fcb104313154679f89ac22c1947c713a65d) Reviewed-on: http://gerrit.openafs.org/9019 Reviewed-by: Michael Meffie Reviewed-by: Ken Dreyer Tested-by: Ken Dreyer Reviewed-by: Andrew Deason Reviewed-by: Stephan Wiesand Reviewed-by: Jeffrey Altman