2004-03-22 05:40 jaltman * src/WINNT/afsd/afsd_service.c: DELTA uninstall-exception-handler-20040321 AUTHOR jaltman@mit.edu Before we shut down the service and return control to the service manager uninstall the exception handler before it gets unloaded from the process. 2004-03-22 04:09 jaltman * src/WINNT/afsd/afsd_service.c: DELTA power-mgmt-20040321 AUTHOR jaltman@mit.edu #define REGISTER_POWER_MANAGEMENT 2004-03-22 04:07 jaltman * src/WINNT/afsd/afsd_flushvol.c: DELTA power-mgnt-close-handles-20040321 AUTHOR jaltman@mit.edu Close the Handles before terminating the thread to ensure that additional power events cannot be queued during shutdown. 2004-03-21 23:03 jaltman * src/WINNT/install/NSIS/OpenAFS.nsi: DELTA nofindlanabyname-20040321 AUTHOR jaltman@mit.edu Disable the Find Lana By Name functionality for 1.3.61 because it appears to be causing grief for too many people. 2004-03-21 21:35 jaltman * src/config/NTMakefile.i386_nt40: DELTA version-1-3-6100-20040321 AUTHOR jaltman@mit.edu update version to 1.3.6100 2004-03-21 20:56 jaltman * src/WINNT/install/NSIS/OpenAFS.nsi: DELTA nsis-installer-20040321 AUTHOR jaltman@mit.edu Check both Client and Server for unsupported previous installation 2004-03-21 20:41 jaltman * src/WINNT/install/NSIS/: NTMakefile, OpenAFS.nsi: DELTA nsis-installer-20040321 AUTHOR jaltman@mit.edu Remove Rob's new way of installing services as it does not appear to work properly. Add in code to test the legitimacy of the upgrade to ensure we don't try to upgrade an old IBM AFS version that isn't supported Make sure that the only AFS in the PATH is ours and that we are only in once. Add the TransarcAFSDaemon entry into the Control\NetworkProviders::Order value to support Integrated Login Build service.exe and killer.exe with static libraries to avoid run-time dependencies at install and uninstall time 2004-03-21 19:48 jaltman * src/WINNT/afsd/cm_cell.c: DELTA debug-log-20040321 AUTHOR jaltman@mit.edu A more informative log message plus fix uninitialized variable 2004-03-21 11:41 jaltman * src/volser/vos.c: DELTA VLCallBack-vos-20040321 AUTHOR jaltman@mit.edu The variable 'm_unique' is an afs_uint32 where the desired parameter must be of type struct VLCallBack when attempting to call VL_GetAddrs. I do not know how this code ever worked on any platform as the stack was being overwritten. This produced binary, vos.exe on windows, also generates massive memory leaks. I do not think we care all that much because the utility does not stay around all that long. However, the fact that the API makes it so easy to lose memory is scary. 2004-03-21 05:24 jaltman * src/WINNT/install/NSIS/: OpenAFS.nsi, ServiceLib.nsh: DELTA nsis-service-20040320 AUTHOR jaltman@mit.edu Incorporate a new NSIS library ServiceLib.nsh which will allow us to avoid using the Service.exe which we must build from Service.cpp 2004-03-21 04:27 jaltman * doc/txt/winnotes/registry.txt: DELTA registry-20040320 AUTHOR jaltman@mit.edu Document "NoFindLanaByName" 2004-03-21 03:12 jaltman * src/WINNT/client_config/drivemap.cpp: DELTA more-optimizations-20040320 AUTHOR jaltman@mit.edu Replace all calls to lana_GetNetbiosName with GetClientNetbiosName which performs the local caching 2004-03-21 03:05 jaltman * src/WINNT/client_config/drivemap.cpp: DELTA find-netbios-optimize-20040320 AUTHOR jaltman@mit.edu In Mount_ReadSubmount() cache the first response to GetNetbiosName() since the result won't change and the work necessary to get the result is considerable. We don't want to be calling it loops over and over again. 2004-03-20 18:42 jaltman * src/WINNT/afsd/afsd_flushvol.c: DELTA prevent-crash-at-shutdown-20040320 AUTHOR jaltman@mit.edu The Power Management Exit routine was instructing the thread to terminate but was not waiting for the conclusion of the operation before returning control to the caller. This allows the service to pass control to the Service Manager before cleanup was properly completed. 2004-03-20 18:00 jaltman * src/WINNT/client_config/: RegistrySupport.cpp, afs_config.h, config.cpp, config.h, dlg_automap.cpp, drivemap.cpp: DELTA per-user-registry-20040320 AUTHOR jaltman@mit.edu Rename existing registry Read/Write functions to Global Add new registry functions to support Per User Read/Write operations Clean up references to Registry Key strings Change "ShowTrayIcon" to be a "Per User" item from a "Global" item 2004-03-20 17:23 jaltman * src/WINNT/afsd/: cm_ioctl.c, cm_server.c, cm_volume.c: DELTA fs-setserverprefs-bug-20040320 AUTHOR jaltman@mit.edu FIXES 3555 Rodney Dyer (UNCC) reported that the "fs setserverprefs" command if issued multiple times would result in the AFSD server becoming unresponsive. This appears to have been caused by improper use of writeLocks, a failure to use writeLocks when necessary, and improper reference counting on the cm_server_t data structures placed into the cm_allServersp list. 2004-03-20 07:55 jaltman * src/WINNT/client_config/tab_drives.cpp: DELTA tab-drives-20040319 AUTHOR jaltman@mit.edu the mount root is used to define mount paths not the netbios name 2004-03-20 01:03 jaltman * src/WINNT/install/NSIS/OpenAFS.nsi: DELTA use-dns-install-fix-20040319 AUTHOR jaltman@mit.edu allow use of dns to be configurable 2004-03-20 01:01 jaltman * src/WINNT/client_creds/: afskfw-int.h, afskfw.c, afswiz.cpp, creds.cpp, creds.h, credstab.cpp: DELTA non-kfw-probe-fix-20040319 AUTHOR jaltman@mit.edu Fix the non-KFW case of the KDC Probe. Prevent infinite loop. 2004-03-20 00:56 jaltman * src/config/NTMakefile.i386_nt40: DELTA version-update-20040319 AUTHOR jaltman@mit.edu Update version to 1.3.6090 2004-03-19 19:50 jaltman * src/WINNT/afsd/: cm_config.c, cm_dns.c: DELTA dns-fixes-20040319 AUTHOR jaltman@mit.edu Reorganize some debug statements to put them in more consistent locations Do not initialize the internal dns support if using the Windows DNS API. (Win2000 and above) 2004-03-19 19:44 jaltman * src/WINNT/install/NSIS/AFSCell.ini: DELTA nsis-installer-20040319 AUTHOR jaltman@mit.edu Fix: The use a provided CellServDB file option was not working. You can't compare a filename to "1" and expect it to work. Add: Make the use of DNS optional and default it to off. 2004-03-19 16:38 rees * src/afs/OBSD/osi_vnodeops.c: DELTA obsd-vnops-warnings-20040319 AUTHOR rees@umich.edu eliminate compiler warnings 2004-03-19 15:37 rees * src/afs/FBSD/osi_vnodeops.c: DELTA freebsd-mkdir-panic-20040319 AUTHOR rees@umich.edu don't vput(dvp) on error return from afs_mkdir (vfs already does this) bug found by, and fix tested by, adridg@sci.kun.nl 2004-03-19 07:58 shadow * src/afs/: afs_osi.c, IRIX/osi_machdep.h: DELTA irix-ucred-is-really-cred-20040319 AUTHOR shadow@dementia.org FIXES 3651 gotta wonder what crack monkey came up with this AFS_UCRED is ucred in osi_machdep.h, and ucred is redefined to cred in osi_vfs.h whatever 2004-03-19 05:16 jaltman * src/WINNT/client_creds/afskfw.c: DELTA getipaddrlist-20040318 AUTHOR jaltman@mit.edu Improve error checking in GetNumOfIpAddrs to prevent potential invalid memory access if the IP Address Table cannot be accessed. (win2000 with no privs) 2004-03-19 03:52 jaltman * src/WINNT/afsd/afslogon.c: DELTA afslogon-20040318 AUTHOR jaltman@mit.edu Fix memory deallocation errors (never call free() on memory allocated by GlobalAlloc() or LocalAlloc()) Modify event logging to be consistent between High and Low Security Only generate a random user name when using High Security. Use the normal user name when running with Low security. 2004-03-19 01:09 jaltman * src/WINNT/client_creds/afskfw.c: DELTA notifyaddrchange-20040318 AUTHOR jaltman@mit.edu NotifyAddrChange() on Win2000 without privs fails. Detect the failure and terminate the IPChangeMonitor thread to prevent an infinite loop eating up system resources. Anyone have a clue which bits are required? 2004-03-18 06:13 jaltman * src/WINNT/afsd/smb3.c: DELTA the-correct-mkdir-fix-20040318 AUTHOR jaltman@mit.edu Apply the correct file including the fix to the MIT recursive directory creation patch. 2004-03-18 06:10 jaltman * src/WINNT/afsd/smb3.c: DELTA mkdir-fix-20040318 AUTHOR jaltman@mit.edu Fix recursive directory creation from MIT for single component case.